Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update microbatch end_time to the batch_size ceiling #10883

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

QMalcolm
Copy link
Contributor

Resolves #10868

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@QMalcolm QMalcolm added the Skip Changelog Skips GHA to check for changelog file label Oct 18, 2024
@cla-bot cla-bot bot added the cla:yes label Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.43%. Comparing base (8be0635) to head (3e2b3e2).

❗ There is a different number of reports uploaded between BASE (8be0635) and HEAD (3e2b3e2). Click for more details.

HEAD has 17 uploads less than BASE
Flag BASE (8be0635) HEAD (3e2b3e2)
integration 18 4
unit 3 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10883      +/-   ##
==========================================
- Coverage   89.20%   83.43%   -5.78%     
==========================================
  Files         183      183              
  Lines       23438    23445       +7     
==========================================
- Hits        20909    19562    -1347     
- Misses       2529     3883    +1354     
Flag Coverage Δ
integration 83.43% <25.00%> (-3.13%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 83.43% <25.00%> (-5.78%) ⬇️
Integration Tests 83.43% <25.00%> (-3.13%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Invalid where filter for latest batch when event_column is of type date
1 participant