Unable to override macros in adapter

[mikaelene]

Describe the bug

Some of the standard dbt macros can't be overridden by an adapter. I.e. Test, snapshots. This is present since dbt v0.16.0

Steps To Reproduce

Create an adapter the aims to override the standard macro snapshot_check_strategy. This has made it impossible for the dbt-sqlserver adapter to follow along with newer dbt verison.

Expected behavior

Expects that the macro is overridden by the adapter version.

Screenshots and log output

If applicable, add screenshots or log output to help explain your problem.

System information

Which database are you using dbt with?

• postgres
• redshift
• bigquery
• snowflake
• other (specify: SQL Server

The output of dbt --version:

installed version: 0.17.0

The operating system you're using:
Osx and windows

The output of python --version:
Python 3.7.7

Additional context

Add any other context about the problem here.

[drewbanin]

thanks for opening this issue @mikaelene! The issue you ran into specifically was around overriding the snapshot_check_strategy macro specifically, right? Or were there other specific macros that you were unable to override in the dbt-sqlserver plugin?

[mikaelene]

it was specifically snapshot_check_strategy. But I had the same issue for all tests macros in 0.16. I solved that with a workaround solution in #2414. But I think that there is probably a general problem that some macros can't be overridden since 0.16

[dataders]

@mikaelene looks like the bugfix is slated for 0.18.0 #2590
Perhaps I'll pull dbt's dev/master and see if things are working properly?