Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YAML selectors to manifest #2693

Closed
jtcohen6 opened this issue Aug 10, 2020 · 0 comments · Fixed by #2866
Closed

Add YAML selectors to manifest #2693

jtcohen6 opened this issue Aug 10, 2020 · 0 comments · Fixed by #2866
Assignees
Labels
artifacts enhancement New feature or request

Comments

@jtcohen6
Copy link
Contributor

Describe the feature

Add a representation of YAML selectors to manifest.json, to support rendering in the docs site (dbt-labs/dbt-docs#119) and other downstream consumers.

How best to render YAML-defined selector logic into JSON? Here's @drewbanin in that issue:

  • A json representation (not the raw YAML) would be ideal
  • We probably do not want an entire list of nodes that would be matched by each selector, but would instead benefit from the "expanded" set of node selector description. It would be ideal if the node shorthand (eg models/my_dir/everything.*+) was expanded out into its full json object representation. This will make it easiest for the docs site (or other artifact consumers) to operate on IMO.

Describe alternatives you've considered

  • Excluding YAML selector support from the docs site or downstream metadata consumers
  • ???

Who will this benefit?

  • Everyone who starts using YAML selectors in v0.18.0
@jtcohen6 jtcohen6 added the enhancement New feature or request label Aug 10, 2020
@jtcohen6 jtcohen6 added this to the 0.19.0 milestone Aug 10, 2020
@gshank gshank self-assigned this Nov 2, 2020
gshank added a commit that referenced this issue Nov 10, 2020
…rs-to-manifest

Save selector dictionary and write out in manifest [#2693][#2800]
iknox-fa pushed a commit that referenced this issue Feb 8, 2022
automatic commit by git-black, original commits:
  74316bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifacts enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants