[CT-1508] When a seed succeeds, LogSeedResult shows result.status when it should show result.message

[jtcohen6]

Background

As a general rule, when a node finishes running and returns its result, the result.message is either the database-specific "success message" (short) or "error message" (verbose).

When a seed succeeds:

    {
      "status": "success",
      "timing": [...],
      "thread_id": "Thread-1 (worker)",
      "execution_time": 0.08353090286254883,
      "adapter_response": {
        "_message": "INSERT 5",
        "code": "INSERT",
        "rows_affected": 5
      },
      "message": "INSERT 5",
      "failures": null,
      "unique_id": "seed.test.test_seed"
    }

When a seed fails:

    {
      "status": "error",
      "timing": [],
      "thread_id": "Thread-1 (worker)",
      "execution_time": 0.022258996963500977,
      "adapter_response": {},
      "message": "Compilation Error in seed test_seed (seeds/test_seed.csv)\n  Row 1 has 3 values, but Table only has 2 columns.\n  \n  > in macro materialization_seed_default (macros/materializations/seeds/seed.sql)\n  > called by seed test_seed (seeds/test_seed.csv)",
      "failures": null,
      "unique_id": "seed.test.test_seed"
    }

Our habit has been:

• success: show the success message inline
• error: just the word ERROR inline, and print the full error message at invocation end

What changed

We standardized these in #6174. Specifically, the status being passed into LogSeedResult is now always result.status. Previously, in the case of seed "success," this was result.message (diff).

Example

Running dbt seed in v1.3:

14:53:04  1 of 1 START seed file dbt_jcohen.test_seed .................................... [RUN]
14:53:04  1 of 1 OK loaded seed file dbt_jcohen.test_seed ................................ [INSERT 5 in 0.08s]

Running dbt seed using latest main changes (1.4.0-a1):

14:53:16  1 of 1 START seed file dbt_jcohen.test_seed .................................... [RUN]
14:53:16  1 of 1 OK loaded seed file dbt_jcohen.test_seed ................................ [success in 0.09s]

Resolution

We should keep our old habit:

• success: show the short database-specific success message inline
• error: show the status (ERROR) inline, and the database-specific success message further down (invocation summary)

@gshank's proposal:

So probably we should save both 'status' and 'message' in the structured log and differentiate in the message construction

I noticed this while running dbt seed. We should also validate that this change hasn't occurred for other resource types.

[gshank]

This was fixed in pull request #6293