CT 1537 fix event test and rename a couple of fields #6293
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
gshank
requested review from
peterallenwebb
and removed request for
McKnight-42
| @@ -16,7 +16,7 @@ | |||
| disallow_secret_env_var, | |||
| ) | |||
| from dbt.events.functions import fire_event, get_invocation_id | |||
| from dbt.events.types import MacroEventInfo, MacroEventDebug | |||
| from dbt.events.types import JinjaLogInfo, JinjaLogDebug | |||
There was a problem hiding this comment.
Along these same lines there's also a GeneralMacroWarning that is the catchall for warn defined in exceptions.py. It's worth renaming that along with these.
There was a problem hiding this comment.
It doesn't look like it's actually used anywhere. Can we just remove it?
There was a problem hiding this comment.
So it's exported into the context. So should we call it JinjaLogWarning?
There was a problem hiding this comment.
I went with JinjaLogWarning.
| @@ -15,6 +15,7 @@ message EventInfo { | |||
| string thread = 7; | |||
| google.protobuf.Timestamp ts = 8; | |||
| map<string, string> extra = 9; | |||
| string category = 10; | |||
There was a problem hiding this comment.
Is this eventually going to be the log category? Am I missing how this gets populated?
There was a problem hiding this comment.
Yeah, right now it's just a placeholder. Eventually we'll populate it somehow...
There was a problem hiding this comment.
Is there an issue so we don't lose the fact we still need to actually populate it?
There was a problem hiding this comment.
Mostly it's your ticket #5958.
resolves #6292
Description
The event unit test was broken and some of the tests weren't actually doing anything. This fixes that, removes the lists of events from the bottom of the types.py and test_types.py files and moves them into test_events.py test file. It also renames a few tests.
Checklist
changie newto create a changelog entry