Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-3091] Add SavedQuery node #8594

Closed
Tracked by #8125
QMalcolm opened this issue Sep 8, 2023 · 0 comments · Fixed by #8798
Closed
Tracked by #8125

[CT-3091] Add SavedQuery node #8594

QMalcolm opened this issue Sep 8, 2023 · 0 comments · Fixed by #8798
Assignees
@QMalcolm
Labels
Impact: CA Impact: SL semantic Issues related to the semantic layer

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Sep 8, 2023 •
edited
Loading

Context

DSI will be adding a SavedQuery protocol which the semantic manifest should have a list of under saved_queries. This is outlined in dbt-labs/dbt-semantic-interfaces#144. This is necessary to support the saved query functionality in MetricFlow (dbt-labs/metricflow#765).

Things we do know

  • SavedQuery nodes will depend on Metric nodes
  • SavedQuery nodes will have
    • a name
    • an optional description
    • a query object that has the following
      • metrics a list of strings (that they're valid metrics is handled by the DSI provided validator)
      • group_bys a list of strings (that they have a valid format is handled by the DSI provided validator)
      • where a WhereFilter object (should be specified as a string by the user, and we convert to an object when parsing the unparsed node)

Necessary work

  • Define an unparsed version of the node
  • Define a manifest version of the node
  • Define schema_yaml_reader process for going from the unparsed node to the manifest node
  • Define a lookup utility for resolvingSavedQuery nodes
  • Handle SavedQuery unique_ids in manifest.expect
  • partial parsing of SavedQuery nodes
@QMalcolm QMalcolm mentioned this issue Sep 8, 2023
Closed
@github-actions github-actions bot changed the title Add SavedQuery node [CT-3091] Add SavedQuery node Sep 8, 2023
@QMalcolm QMalcolm added semantic Issues related to the semantic layer more_information_needed Refinement Maintainer input needed labels Sep 8, 2023
@QMalcolm QMalcolm removed more_information_needed Refinement Maintainer input needed labels Sep 15, 2023
@QMalcolm QMalcolm mentioned this issue Oct 9, 2023
Merged
5 tasks
@dbeatty10 dbeatty10 mentioned this issue Mar 24, 2024
Merged
2 tasks
mirnawong1 added a commit to dbt-labs/docs.getdbt.com that referenced this issue Mar 25, 2024
@mirnawong1
The "saved_query" selector method (#5150)
4d1297d 
[Preview](https://docs-getdbt-com-git-dbeatty10-patch-1-dbt-labs.vercel.app/reference/node-selection/methods#the-saved_query-method)

## What are you changing in this pull request and why?

The "saved_query" selector method was [added in
v1.7](https://github.com/dbt-labs/dbt-core/blob/1.7.latest/CHANGELOG.md#dbt-core-170---november-02-2023)
by dbt-labs/dbt-core#8594 /
dbt-labs/dbt-core#8798.

## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [x] I have verified all new code examples work as described
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QMalcolm QMalcolm

Labels
Impact: CA Impact: SL semantic Issues related to the semantic layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add SavedQuery nodes dbt-labs/dbt-core
2 participants
@QMalcolm @martynydbt