Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete tests/functional/adapters and trigger dbt-postgres tests to run instead #9513

Open
1 task done
MichelleArk opened this issue Feb 2, 2024 · 0 comments
Open
1 task done
Labels
repo ci/cd Testing and continuous integration for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality user docs [docs.getdbt.com] Needs better documentation

Comments

@MichelleArk
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-core

Short description

In #9492, we removed dbt-postgres and dbt-tests-adapter from dbt-core.

However, to avoid losing test coverage, we left the adapter base test + postgres test definitions in dbt-core, under tests/functional/adapters.

dbt-core should be able to run the integration tests for dbt-postgres, but it should not define them. Their source of truth is in the dbt-tests-adapter and dbt-postgres repos (base + postgres tests respectively) and the current duplication can cause drift. For example, dbt-core will not start running any new tests unless we copy them over from dbt-test-adapters or dbt-postgres manually.

Acceptance criteria

  • dbt/tests/adapter is deleted
  • dbt-core PR commits trigger a run of integration tests in dbt-postgres

Suggested Tests

N/A - CI workflow

Impact to Other Teams

N/A

dbt-postgres will need to have a workflow for running its adapter tests available: dbt-labs/dbt-postgres#4

Will backports be required?

No

Context

No response

@MichelleArk MichelleArk added user docs [docs.getdbt.com] Needs better documentation repo ci/cd Testing and continuous integration for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality labels Feb 2, 2024
@MichelleArk MichelleArk changed the title Delete tests/function/adapters and trigger dbt-postgres tests to run instead Delete tests/functional/adapters and trigger dbt-postgres tests to run instead Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo ci/cd Testing and continuous integration for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

No branches or pull requests

1 participant