-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update codeowners post adapters-decoupling #9688
Conversation
/core/dbt/adapters @dbt-labs/core-adapters | ||
|
||
# Global project (default macros + materializations), starter project | ||
/core/dbt/include @dbt-labs/core-adapters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this still exists but is just the starter_project for dbt init, shouldn't be an adapters concern any longer
https://github.com/dbt-labs/dbt-core/tree/main/core/dbt/include
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9688 +/- ##
==========================================
+ Coverage 87.98% 88.00% +0.01%
==========================================
Files 178 178
Lines 22381 22451 +70
==========================================
+ Hits 19693 19758 +65
- Misses 2688 2693 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment otherwise LGTM
resolves #N/A
Problem
CODEOWNERS was referencing paths / teams that don't exist under dbt-labs!
Solution
Update CODEOWNERS to reflect codebase.
Checklist