Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codeowners post adapters-decoupling #9688

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Update codeowners post adapters-decoupling #9688

merged 3 commits into from
Mar 12, 2024

Conversation

MichelleArk
Copy link
Contributor

resolves #N/A

Problem

CODEOWNERS was referencing paths / teams that don't exist under dbt-labs!

Solution

Update CODEOWNERS to reflect codebase.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@MichelleArk MichelleArk added the Skip Changelog Skips GHA to check for changelog file label Feb 27, 2024
@MichelleArk MichelleArk requested a review from a team as a code owner February 27, 2024 19:14
@cla-bot cla-bot bot added the cla:yes label Feb 27, 2024
/core/dbt/adapters @dbt-labs/core-adapters

# Global project (default macros + materializations), starter project
/core/dbt/include @dbt-labs/core-adapters
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still exists but is just the starter_project for dbt init, shouldn't be an adapters concern any longer

https://github.com/dbt-labs/dbt-core/tree/main/core/dbt/include

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.00%. Comparing base (865b09b) to head (a68bffd).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9688      +/-   ##
==========================================
+ Coverage   87.98%   88.00%   +0.01%     
==========================================
  Files         178      178              
  Lines       22381    22451      +70     
==========================================
+ Hits        19693    19758      +65     
- Misses       2688     2693       +5     
Flag Coverage Δ
integration 85.46% <ø> (+0.02%) ⬆️
unit 62.21% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment otherwise LGTM

@MichelleArk MichelleArk merged commit d9c36c3 into main Mar 12, 2024
56 checks passed
@MichelleArk MichelleArk deleted the fix-codeowners branch March 12, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants