Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add primary/foreign key information in the model level of dbt docs generate #10035

Conversation

salimmoulouel
Copy link

@salimmoulouel salimmoulouel commented Apr 25, 2024

resolves #10034
resolves dbt-labs/dbt-bigquery#1186
resolves dbt-labs/dbt-docs#507

Problem

Primary/foreign key not included in the dbt docs serve when declared at the model level

Solution

Imprive the code

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@salimmoulouel salimmoulouel requested a review from a team as a code owner April 25, 2024 12:13
@cla-bot cla-bot bot added the cla:yes label Apr 25, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@github-actions github-actions bot added the community This PR is from a community member label Apr 25, 2024
@salimmoulouel salimmoulouel force-pushed the feature/include_primary_key_constraint_model_level branch 3 times, most recently from 2c1923a to 41dc638 Compare April 25, 2024 12:27
@salimmoulouel salimmoulouel force-pushed the feature/include_primary_key_constraint_model_level branch from 41dc638 to eed3d87 Compare April 25, 2024 12:31
@salimmoulouel salimmoulouel changed the title add primary key information in the model level of dbt docs generate add primary/foreign key information in the model level of dbt docs generate Apr 25, 2024
@dbeatty10
Copy link
Contributor

The only thing I'm seeing changed in this PR is the core/dbt/task/docs/index.html file.

As mentioned here, this file comes from the dbt-docs repository, and is generated by the dbt maintainers when a release is packaged. So this isn't a file we'd expect to see changed directly by an external contributor, and I'm going to close this particular PR.

But if you made some changes to the dbt-docs repo that you want to propose, could you share screenshots in dbt-labs/dbt-docs#507 and we can discuss further?

@dbeatty10 dbeatty10 closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member
Projects
None yet
2 participants