Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changie doc for microbatch retry functionality #10787

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

QMalcolm
Copy link
Contributor

The changie log was referencing the microbatch epic instead of the specific issues it resolved

Resolves N/A

Problem

I referenced the wrong issue in the changie doc for #10751

Solution

Correct the changie doc

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

The changie log was referencing the microbatch epic instead of the specific
issues it resolved
@QMalcolm QMalcolm marked this pull request as ready for review September 26, 2024 16:04
@QMalcolm QMalcolm requested a review from a team as a code owner September 26, 2024 16:04
@cla-bot cla-bot bot added the cla:yes label Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (1fd4d2e) to head (9ccb151).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10787      +/-   ##
==========================================
+ Coverage   89.03%   89.14%   +0.10%     
==========================================
  Files         182      182              
  Lines       23195    23288      +93     
==========================================
+ Hits        20651    20759     +108     
+ Misses       2544     2529      -15     
Flag Coverage Δ
integration 86.42% <ø> (+0.18%) ⬆️
unit 62.22% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.22% <ø> (+0.03%) ⬆️
Integration Tests 86.42% <ø> (+0.18%) ⬆️

@QMalcolm QMalcolm merged commit 41e4836 into main Sep 26, 2024
68 checks passed
@QMalcolm QMalcolm deleted the qmalcolm--fix-changie-for-microbatch-retry branch September 26, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants