Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate --event-time-start is before --event-time-end #10820

Commits on Oct 3, 2024

  1. Validate that event_time_start is before event_time_end when pass…

    …ed from CLI
    
    Sometimes CLI options have restrictions based on other CLI options. This is the case
    for `--event-time-start` and `--event-time-end`. Unfortunately, click doesn't provide
    a good way for validating this, at least not that I found. Additionaly I'm not sure
    if we have had anything like this previously. In any case, I couldn't find a
    centralized validation area for such occurances. Thus I've gone and added one,
    `validate_option_interactions`. Long term if more validations are added, we should
    add this wrapper to each CLI command. For now I've only added it to the commands that
    support `event_time_start` and `event_time_end`, specifically `build` and `run`.
    QMalcolm committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    13f25cc View commit details
    Browse the repository at this point in the history
  2. Add changie doc

    QMalcolm committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    5dc16b9 View commit details
    Browse the repository at this point in the history
  3. If --event-time-end is not specififed, ensure --event-time-start

    …is less than the current time
    QMalcolm committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ee994c1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ca9b381 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Configuration menu
    Copy the full SHA
    7b995c5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cad0006 View commit details
    Browse the repository at this point in the history