Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for dbt compile overwriting source files #10887

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Myles1
Copy link

@Myles1 Myles1 commented Oct 18, 2024

Resolves #10886

Problem

Running dbt compile can overwrite source files with the newly compiled sql

Solution

Update path building to avoid issues with absolute paths.

The issue appears on this line:

target_write_path = os.path.join(target_path, subdirectory, self.package_name, path)

Consider the case where path is an absolute path.
For example, running this will give the absolute path as the return value, instead of the expected relative path that will be used as the output target file.

>>> os.path.join("target_path", "subdirectory", "package_name", "/absolute/path/project/models/my_model.sql")
'/absolute/path/project/models/my_model.sql'

Following the change in this PR, we can expect this as the result:

>>> os.path.join("target_path", "subdirectory", "package_name", "models/my_model.sql")
'target_path/subdirectory/package_name/models/my_model.sql'

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@Myles1 Myles1 requested a review from a team as a code owner October 18, 2024 22:05
Copy link

cla-bot bot commented Oct 18, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @Myles1

@github-actions github-actions bot added the community This PR is from a community member label Oct 18, 2024
@Myles1
Copy link
Author

Myles1 commented Oct 18, 2024

CLA should be signed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Running dbt compile can overwrite source files
1 participant