Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin internal dependencies with upper bounds #10894

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Oct 21, 2024

Resolves #10895

Problem

We introduce some dev thrash with some changes to dbt-common. Most recently we updated an error message that caused tests in 1.8 to break.

Solution

Give dbt-common and dbt-adapters an upper bound pin. Stop point dev-dependencies to main.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@emmyoop emmyoop requested a review from a team as a code owner October 21, 2024 18:16
@cla-bot cla-bot bot added the cla:yes label Oct 21, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.27%. Comparing base (1285917) to head (e10f16d).
Report is 1 commits behind head on 1.8.latest.

Additional details and impacted files
@@              Coverage Diff               @@
##           1.8.latest   #10894      +/-   ##
==============================================
- Coverage       88.27%   88.27%   -0.01%     
==============================================
  Files             181      181              
  Lines           22796    22796              
==============================================
- Hits            20124    20123       -1     
- Misses           2672     2673       +1     
Flag Coverage Δ
integration 85.45% <ø> (-0.01%) ⬇️
unit 62.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop requested a review from gshank October 21, 2024 18:39
@emmyoop emmyoop merged commit 69742e1 into 1.8.latest Oct 21, 2024
57 checks passed
@emmyoop emmyoop deleted the er/pin-dependencies branch October 21, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants