Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen Type in TimingInfo #10897

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Loosen Type in TimingInfo #10897

merged 3 commits into from
Oct 21, 2024

Conversation

peterallenwebb
Copy link
Contributor

Problem

An overly restrictive type annotation caused problems deserializing previously stored run results.

Solution

Loosen the annotation back to its original type.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • [] I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@peterallenwebb peterallenwebb requested a review from a team as a code owner October 21, 2024 22:31
@cla-bot cla-bot bot added the cla:yes label Oct 21, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@peterallenwebb peterallenwebb added the Skip Changelog Skips GHA to check for changelog file label Oct 21, 2024
@MichelleArk MichelleArk added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.18%. Comparing base (7920b0e) to head (67f9b8a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10897      +/-   ##
==========================================
+ Coverage   89.15%   89.18%   +0.02%     
==========================================
  Files         183      183              
  Lines       23443    23443              
==========================================
+ Hits        20901    20908       +7     
+ Misses       2542     2535       -7     
Flag Coverage Δ
integration 86.46% <100.00%> (+0.02%) ⬆️
unit 62.12% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.12% <100.00%> (ø)
Integration Tests 86.46% <100.00%> (+0.02%) ⬆️

@peterallenwebb peterallenwebb requested a review from a team as a code owner October 21, 2024 22:40
@peterallenwebb peterallenwebb requested review from dansahagian and removed request for a team October 21, 2024 22:40
@MichelleArk MichelleArk merged commit 3d96b4e into main Oct 21, 2024
60 checks passed
@MichelleArk MichelleArk deleted the paw/loosen-type-timing-info branch October 21, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants