[Tidy first] move microbatch compilation to .compile method #11063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
MichelleArk
added
Skip Changelog
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11063 +/- ##
==========================================
- Coverage 89.16% 89.13% -0.03%
==========================================
Files 183 183
Lines 23783 23783
==========================================
- Hits 21205 21198 -7
- Misses 2578 2585 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
MichelleArk
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
(cherry picked from commit 1b7d9b5)
MichelleArk
pushed a commit
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving compilation to the .compile method for more narrow responsibility in the _execute_microbatch_materialization method!
Additional snowflake testing: https://github.com/dbt-labs/dbt-snowflake/actions/runs/12059876357