Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put an upper bound on bigquery #2007

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Dec 13, 2019

The google-cloud-bigquery package recently got upped to 1.23.0, which has an implicit dependency on six>=1.13.0. Unfortunately, google-cloud-bigquery doesn't specify a six version, and its dependency google-cloud-core only specifies six>=1.10.

See the issue here: googleapis/google-cloud-python#9965

This PR both explicitly requires six>=1.13.0 to resolve the hidden dependency.

This also excludes newer versions of google-cloud-bigquery/google-cloud-core than what's out there to hopefully avoid any new surprises.

Unfortunately this will only fix 0.15.1 and up, but that's really all we can do unless we want to cut a 0.14.5.

@beckjake beckjake requested a review from drewbanin December 13, 2019 21:01
@cla-bot cla-bot bot added the cla:yes label Dec 13, 2019
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@beckjake beckjake merged commit 0fe5fb6 into dev/0.15.1 Dec 13, 2019
@beckjake beckjake deleted the fix/bigquery-upper-bounds branch December 13, 2019 21:31
@drewbanin drewbanin added this to the 0.15.1 milestone Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants