Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add debug query method #2817

Merged

Conversation

zmac12
Copy link
Contributor

@zmac12 zmac12 commented Oct 8, 2020

resolves #2751

Description

Adds a debug_query method to the base adapter that will allow for plugin authors to add their own debug query. Intended for all use cases where the database doesn't support 'select 1 as id' as a valid query.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Oct 8, 2020
@jtcohen6
Copy link
Contributor

jtcohen6 commented Oct 8, 2020

@zmac12 This code change is looking good to me. Could you:

@zmac12
Copy link
Contributor Author

zmac12 commented Oct 8, 2020

Will do!

Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution @zmac12

@jtcohen6 jtcohen6 merged commit fd5e10c into dbt-labs:dev/kiyoshi-kuromiya Oct 8, 2020
@zmac12 zmac12 deleted the feature/addDebugQueryMethod branch October 12, 2020 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update debug task to make the debug query an adapter method
2 participants