Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agate requirement from <1.6.2,>=1.6 to >=1.6,<1.6.4 in /core #3585

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 16, 2021

Updates the requirements on agate to permit the latest version.

Changelog

Sourced from agate's changelog.

1.6.3 - July 15, 2021

  • feat: :meth:.Table.from_csv accepts a row_limit keyword argument. (#740)
  • feat: :meth:.Table.from_json accepts an encoding keyword argument. (#734)
  • feat: :meth:.Table.print_html accepts a max_precision keyword argument, like :meth:.Table.print_table. (#753)
  • feat: :class:.TypeTester accepts a null_values keyword argument, like individual data types. (#745)
  • feat: :class:.Min, :class:.Max and :class:.Sum (#735) work with :class:.TimeDelta.
  • feat: :class:.FieldSizeLimitError includes the line number in the error message. (#681)
  • feat: :class:.csv.Sniffer warns on error while sniffing CSV dialect.
  • fix: :meth:.Table.normalize works with basic processing methods. (#691)
  • fix: :meth:.Table.homogenize works with basic processing methods. (#756)
  • fix: :meth:.Table.homogenize casts compare_values and default_row. (#700)
  • fix: :meth:.Table.homogenize accepts tuples. (#710)
  • fix: :meth:.TableSet.group_by accepts input with no rows. (#703)
  • fix: :class:.TypeTester warns if a column specified by the force argument is not in the table, instead of raising an error. (#747)
  • fix: Aggregations return None if all values are None, instead of raising an error. Note that Sum, MaxLength and MaxPrecision continue to return 0 if all values are None. (#706)
  • fix: Ensure files are closed when errors occur. (#734)
  • build: Make PyICU an optional dependency.

1.6.2 - March 10, 2021

  • feat: :meth:.Date.__init__ and :meth:.DateTime.__init__ accepts a locale keyword argument (e.g. :code:en_US) for parsing formatted dates. (#730)
  • feat: :meth:.Number.cast casts True to 1 and False to 0. (#733)
  • fix: :meth:.utils.max_precision ignores infinity when calculating precision. (#726)
  • fix: :meth:.Date.cast catches OverflowError when type testing. (#720)
  • Included examples in Python package. (#716)

1.6.1 - March 11, 2018

  • feat: :meth:.Table.to_json can use Decimal as keys. (#696)
  • fix: :meth:.Date.cast and :meth:.DateTime.cast no longer parse non-date strings that contain date sub-strings as dates. (#705)
  • docs: Link to tutorial now uses version through Sphinx to avoid bad links on future releases. (#682)

1.6.0 - February 28, 2017

This update should not cause any breaking changes, however, it is being classified as major release because the dependency on awesome-slugify, which is licensed with GPLv3, has been replaced with python-slugify, which is licensed with MIT.

  • Suppress warning from babel about Time Zone expressions on Python 3.6. (#665)
  • Reimplemented slugify with python-slugify instead of awesome-slugify. (#660)
  • Slugify renaming of duplicate values is now consistent with :meth:.Table.init. (#615)

1.5.5 - December 29, 2016

  • Added a "full outer join" example to the SQL section of the cookbook. (#658)
  • Warnings are now more explicit when column names are missing. (#652)

... (truncated)

Commits
  • dc0684a build: Iterate the version number
  • 9f3808b test: Skip test that inexplicably fails intermittently on Linux on Python 3
  • ca66f71 chore: Make charts.py executable
  • 091957b chore: check-manifest
  • 4847a18 chore: isort, add pre-commit configuration to avoid such issues
  • 436444c chore: Remove outdated comment
  • 01cdc12 test: Fix sys.version_info comparison
  • a24ea5f test: Skip test that inexplicably fails on Linux on Python 3.6
  • daa04be chore: flake8
  • b4f7b71 test: Expand test failure message for debugging
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Changes to the version of dbt dependencies python Pull requests that update Python code labels Jul 16, 2021
@cla-bot cla-bot bot added the cla:yes label Jul 16, 2021
@dependabot dependabot bot temporarily deployed to Postgres July 16, 2021 00:22 Inactive
@dependabot dependabot bot temporarily deployed to Bigquery July 16, 2021 00:22 Inactive
@dependabot dependabot bot temporarily deployed to Bigquery July 16, 2021 00:22 Inactive
@dependabot dependabot bot temporarily deployed to Snowflake July 16, 2021 00:22 Inactive
@dependabot dependabot bot temporarily deployed to Snowflake July 16, 2021 00:22 Inactive
@dependabot dependabot bot temporarily deployed to Redshift July 16, 2021 00:22 Inactive
@dependabot dependabot bot temporarily deployed to Redshift July 16, 2021 00:22 Inactive
@dependabot dependabot bot force-pushed the dependabot/pip/core/agate-gte-1.6-and-lt-1.6.4 branch from bfbc28f to b052d63 Compare August 6, 2021 00:13
@leahwicz
Copy link
Contributor

leahwicz commented Aug 6, 2021

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 6, 2021

Looks like this PR is already up-to-date with develop! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@jtcohen6
Copy link
Contributor

jtcohen6 commented Aug 6, 2021

We should double-check before merging this one: agate==1.6.2 introduced some new dependencies that bricked installations for a number of users (#3160).

@dependabot dependabot bot force-pushed the dependabot/pip/core/agate-gte-1.6-and-lt-1.6.4 branch 2 times, most recently from edde10d to 9a15323 Compare September 27, 2021 00:39
@dependabot dependabot bot force-pushed the dependabot/pip/core/agate-gte-1.6-and-lt-1.6.4 branch 2 times, most recently from 8c25482 to 7443e4c Compare October 25, 2021 00:36
@jtcohen6
Copy link
Contributor

jtcohen6 commented Nov 7, 2021

@dependabot rebase

Updates the requirements on [agate](https://github.com/wireservice/agate) to permit the latest version.
- [Release notes](https://github.com/wireservice/agate/releases)
- [Changelog](https://github.com/wireservice/agate/blob/master/CHANGELOG.rst)
- [Commits](wireservice/agate@1.6.0...1.6.3)

---
updated-dependencies:
- dependency-name: agate
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/core/agate-gte-1.6-and-lt-1.6.4 branch from 7443e4c to 4663283 Compare November 7, 2021 15:10
@jtcohen6
Copy link
Contributor

jtcohen6 commented Nov 7, 2021

Paraphrasing from #3413 (comment), the two issues in agate==1.6.2 have been resolved:

So I think we could go ahead with this upgrade, assuming the tests still pass. We should keep the pin very tight given the history of changes included in patch releases.

@jtcohen6 jtcohen6 requested a review from kwigley November 8, 2021 17:09
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After synchronous discussion, we're good to move ahead with this

@jtcohen6 jtcohen6 merged commit f8cefa3 into main Nov 8, 2021
@jtcohen6 jtcohen6 deleted the dependabot/pip/core/agate-gte-1.6-and-lt-1.6.4 branch November 8, 2021 17:41
MartinNowak added a commit to 7Learnings/dbt-core that referenced this pull request Dec 31, 2021
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
…3585)

Updates the requirements on [agate](https://github.com/wireservice/agate) to permit the latest version.
- [Release notes](https://github.com/wireservice/agate/releases)
- [Changelog](https://github.com/wireservice/agate/blob/master/CHANGELOG.rst)
- [Commits](wireservice/agate@1.6.0...1.6.3)

---
updated-dependencies:
- dependency-name: agate
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

automatic commit by git-black, original commits:
  f8cefa3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes dependencies Changes to the version of dbt dependencies python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants