Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove len check from integration test #4123

Closed
wants to merge 1 commit into from

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Oct 22, 2021

resolves #4052

Description

len() check was causing an error where, when run in CI, there were 4 manifest nodes, but there should have only been three (1 model and 2 tests).

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

len check was causing an error where, when run in CI, there were 4 manifest nodes, but there should have only been three (1 model and 2 tests)
@cla-bot cla-bot bot added the cla:yes label Oct 22, 2021
@emmyoop emmyoop marked this pull request as ready for review October 22, 2021 21:27
@leahwicz
Copy link
Contributor

@emmyoop do we know why CI doesn't have 3 nodes like expected and is showing 4?

@emmyoop emmyoop closed this Nov 2, 2021
@emmyoop emmyoop deleted the er/patch-generic-test-bug branch November 2, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants