-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidying up materialization logic: relation names, cache loading, etc #5221
Conversation
08bb9ef
to
a5abe20
Compare
Code quality checks are failing because of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me
a5abe20
to
81e6a2b
Compare
Hmm not sure why Snyk didn't run. Going to try my other special move, closing and reopening |
Thanks for reviewing @McKnight-42! I'm going to merge, since this is really just a rename-style refactor, and all the tests are passing :) |
Inspired by:
Description
load_relation
toload_cached_relation
(with backwards compat). Use this macro much more frequently, rather thanadapter.get_relation
(verbose + harder to read)existing_relation
(neverold_relation
),temp_relation
,intermediate_relation
,backup_relation
. AlwaysX_relation
, neverX_identifier
.get_create_table_as_sql
orget_create_view_as_sql
, instead ofcreate_table_as
orcreate_view_as
(per Reorganize global project (macros) #4154). Long-term goal: better distinguish between static macros that-> str
("returns SQL"), and "dirty" macros that-> Result
(runs query by itself, a laadapter.rename_relation
).main
, this will need to be ported over to the new test location hereChecklist
changie new
to create a changelog entry