draft for support python in base mat macros #6127
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
| {% elif full_refresh_mode %} | ||
| {% set build_sql = get_create_table_as_sql(False, intermediate_relation, sql) %} |
There was a problem hiding this comment.
@jtcohen6 any concern moving from get_create_table_as_sql to create_table_as?
There was a problem hiding this comment.
Heh — technically, create_table_as is the old/originally name, get_create_table_as_sql was meant to be more consistent with the fact that macros which don't actually perform a side effect (run_query), but simply return code (SQL) as a string, were named get_x_sql. It's a convention we have been very imperfect about following.
We made this change in the leadup to v1.0, based on feedback from @dataders (before he worked with us!): #4154 (review)
|
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
|
Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers. |
resolves #
Description
Checklist
changie newto create a changelog entry