Buck pkg mgmt #645

b-ryan · 2018-01-29T20:56:16Z

No description provided.

* fix for bad env_var exception * overwrite target with compiled values * fixes env vars, adds test. Auto-compile profile/target args

* improvements for code that runs in hooks * fix error message note * typo

…#566)

* tojson was added in jinja 2.9 * requirements

* fix package-defined schema test macros * create a dummy Relation in parsing * fix for bq quoting (#565)

* bump snowflake, remove pyasn1 * change requirements.txt

* 090 docs * Update CHANGELOG.md

* Raise CompilationException on duplicate model Extend tests * Ignore disabled models in parse_sql_nodes Extend tests for duplicate model * Fix preexisting models * Use double quotes consistently Rename model-1 to model-disabled * Fix unit tests * Raise exception on duplicate model across packages Extend tests

* Make run_started_at timezone aware Set run_started_at timezone to UTC Enable timezone change in models Extend requirements Extend tests * Address comments from code review Create modules namespace to context Move pytz to modules Add new dependencies to setup.py

* Add warning for missing constraints. Fixes #592 * fix unit tests

* fix schema tests used in, or defined in packages * don't hardcode dbt test namespace * fix/actually run tests * rm junk

* run hooks in correct order, fixes #590 * add tests * fix tests * pep8

From cffi callback <function _verify_callback at 0x06BF2978>: Traceback (most recent call last): File "c:\projects\dbt\.tox\pywin\lib\site-packages\OpenSSL\SSL.py", line 313, in wrapper _lib.X509_up_ref(x509) AttributeError: module 'lib' has no attribute 'X509_up_ref' From cffi callback <function _verify_callback at 0x06B8CF60>:

* Fixes already opened transaction issue For #602 * Fixes #621

The downloads directory causes problems with the run command because this directory is not a dbt project. Need to download it elsewhere.

drewbanin

Lots of tiny cosmetic comments, but this PR is so solid. Great work! Let me know if you have questions about any of the comments

drewbanin · 2018-02-01T17:21:22Z

dbt/clients/registry.py

+index_cached = memoized(index)
+
+
+def packages(registry_base_url=None):


is this used anywhere? The tinyurl link returns a 404

good catch - the hub.getdbt.com repo did not actually serve the packages.json route. In fact it still isn't unless I just have the URL wrong. How do I get the package JSON from the hub?

@b-ryan we're going to get this live this week @ hub.getdbt.com

Is /api/v1/packages.json the correct path for that json?

yeah - that will be the path once we get the site up!

drewbanin · 2018-02-01T18:21:07Z

dbt/clients/git.py

+    start_sha = None
+    if exists:
+        directory = exists.group(1)
+        logger.info('Updating existing dependency %s.', directory)


i think this is a little too verbose for logger.info -- can we use logger.debug instead? I think that means also changing the checkout function to also use logger.debug which is probably a good idea anyway.

Yeah I noticed that too, particularly because since I wrote some of the deps code to do the checkout at a few different places (just to make the code cleaner) it will always print the repo is already up to date. I can change all the info logs in this module to debug unless you think there are any in particular that should be info.

Yeah, i think that's a good idea. We'll still want to show some info to the user with info-level logging, but i don't think any of that ui-related code belongs in the git client

drewbanin · 2018-02-01T18:27:50Z

dbt/task/deps.py

+            logger.error(
+                'Could not resolve to a single version for Git repo %s!',
+                self.git)
+            logger.error('  Requested versions: %s', requested)
            raise Exception('bad')


Can we throw a better exception here 😂

git dependencies should contain exactly one version. https://github.com/fishtown-analytics/dbt-utils contains: {'master', '0.0.1'}

drewbanin · 2018-02-01T21:51:29Z

dbt/semver.py


                else:
                    match_found = True

-                    print('going down the stack with {}'.format(new_unmet_dependencies))
+                    print('going down the stack with {}'


can we use debug logging for all of these print statements? Or just remove them if not needed anymore

drewbanin · 2018-02-01T21:56:36Z

dbt/task/deps.py

+                   for v in cls.version_to_list(version)]
+        # VersionSpecifier.from_version_string will return None in case of
+        # failure, so we need to iterate again to check if any failed.
+        if any(not isinstance(v, VersionSpecifier) for v in version):


Can we make this error message contain the errant version string? I imagine this could be hard to track down without it

I think it would make more sense to have the underlying semver code throw an exception. Right now it's returning None in a place that appeared to me to make more sense as an exception.

cc @cmcarthur

drewbanin · 2018-02-01T22:01:46Z

dbt/task/deps.py

+
+
+def _parse_package(dict_):
+    if dict_.get('package'):


Can we also check that only one of these is specified? Something like this:

packages: - git: https://github.com/fishtown-analytics/dbt-utils hub: fishtown-analytics/redshift version: 1.0.0

Will probably be a common failure mode for people unfamiliar with yaml

Packages should not contain more than one of ['package', 'git', 'local']; yours has 2 of them - ['package', 'git']

look ok?

drewbanin · 2018-02-01T22:02:26Z

dbt/task/deps.py

-                        package,
-                        cls._convert_version_strings(version_strings))
-
+            dbt.exceptions.raise_dependency_error(


drewbanin · 2018-02-01T22:03:40Z

dbt/task/deps.py

+
+        packages = _read_packages(self.project)
+        if not packages:
+            return


Can we log something like:

Warning: No packages found in dbt_project.yml

Sure - so long as you want that. Are you figure the most common case will include at least one package?

Oh my comment was stupid. Nevermind.

drewbanin · 2018-02-01T22:04:59Z

requirements.txt

@@ -8,7 +8,9 @@ csvkit==0.9.1
 snowplow-tracker==0.7.2
 celery==3.1.23
 voluptuous==0.10.5
-snowflake-connector-python==1.4.0
+snowflake-connector-python==1.4.14


We'll probably want to remove these changes before merging

cmcarthur · 2018-02-02T21:53:14Z

dbt/semver.py

-            return None
+        if not match:
+            raise dbt.exceptions.SemverException(
+                'Could not parse version "{}"'.format(version_string))


drewbanin · 2018-02-03T21:24:32Z

dbt/semver.py


 from dbt.exceptions import VersionsNotCompatibleException
 import dbt.utils

+logger = logging.getLogger(__name__)


We usually do:

from dbt.logger import GLOBAL_LOGGER as logger

Is there any difference to grabbing the logger this way?

Ah I see. Well I have a few thoughts on this. To answer your question, there is a difference. Using __name__ means the logger in this module is scoped to dbt.semver. So you could, for example, use this to filter or format logs for this module differently than everything else. Like

logging.getLogger("dbt.semver").setLevel(logging.ERROR)

But it also helps identify where logs are coming from if you were to put %(name)s in the format of the log messages since the name of the module would be in the logs.

You might not care about this, but one other thing I noticed is GLOBAL_LOGGER does not have a name, it's just:

logger = logging.getLogger()

which is the root logger. I would at least recommend changing this to logger = logging.getLogger("dbt"). Doing so would at least make this a lot simpler, since your logging config could just look like:

root_logger = logging.getLogger() root_logger.setLevel(logging.CRITICAL) logger = logging.getLogger("dbt") logger.setLevel(logging.DEBUG)

and then you can whitelist modules you want to be more chatty instead of blacklisting modules.

I just tested all this out to confirm it's correct and the other thing you'd need to remove is https://github.com/fishtown-analytics/dbt/blob/development/scripts/dbt#L7 -- I find the basicConfig function is usually not helpful for anything other than one-off / simple scripts.

This is super helpful, I think we will do this! Thanks for the heads up!

@b-ryan this worked super well, thanks so much for the tip :)

drewbanin · 2018-02-03T21:26:28Z

@b-ryan this is looking really great. I'm going to continue to test locally over the weekend -- thanks for making those cosmetic changes

* Fix for redshift varchar bug * pep8 on a sql string, smh

* Set global variable overrides on the command line with --vars * pep8 * integration tests for cli vars

* loader for seed data files * Functioning rework of seed task * Make CompilerRunner fns private and impl. SeedRunner.compile Trying to distinguish between the public/private interface for this class. And the SeedRunner doesn't need the functionality in the compile function, it just needs a compile function to exist for use in the compilation process. * Test changes and fixes * make the DB setup script usable locally * convert simple copy test to use seeed * Fixes to get Snowflake working * New seed flag and make it non-destructive by default * Convert update SQL script to another seed * cleanup * implement bigquery csv load * context handling of StringIO * Better typing * strip seeder and csvkit dependency * update bigquery to use new data typing and to fix unicode issue * update seed test * fix abstract functions in base adapter * support time type * try pinning crypto, pyopenssl versions * remove unnecessary version pins * insert all at once, rather than one query per row * do not quote field names on creation * bad * quiet down parsedatetime logger * pep8 * UI updates + node conformity for seed nodes * add seed to list of resource types, cleanup * show option for CSVs * typo * pep8 * move agate import to avoid strange warnings * deprecation warning for --drop-existing * quote column names in seed files * revert quoting change (breaks Snowflake). Hush warnings

…o buck-pkg-mgmt

drewbanin · 2018-02-12T21:19:46Z

TODO :

merge this with the existing PR
s/version/revision for Git packages

* semver resolution * cleanup * remove unnecessary comment * add test for multiples on both sides * add resolve_to_specific_version * local registry * hacking out deps * Buck pkg mgmt (#645) * only load hooks and archives once (#540) * sets schema for node before parsing raw sql (#541) * Fix/env vars (#543) * fix for bad env_var exception * overwrite target with compiled values * fixes env vars, adds test. Auto-compile profile/target args * improvements for code that runs in hooks (#544) * improvements for code that runs in hooks * fix error message note * typo * Update CHANGELOG.md * bump version (#546) * add scope to service account json creds initializer (#547) * bump 0.9.0a3 --> 0.9.0a4 (#548) * Fix README links (#554) * Update README.md * handle empty profiles.yml file (#555) * return empty string (instead of None) to avoid polluting rendered sql (#566) * tojson was added in jinja 2.9 (#563) * tojson was added in jinja 2.9 * requirements * fix package-defined schema test macros (#562) * fix package-defined schema test macros * create a dummy Relation in parsing * fix for bq quoting (#565) * bump snowflake, remove pyasn1 (#570) * bump snowflake, remove pyasn1 * change requirements.txt * allow macros to return non-text values (#571) * revert jinja version, implement tojson hack (#572) * bump to 090a5 * update changelog * bump (#574) * 090 docs (#575) * 090 docs * Update CHANGELOG.md * Update CHANGELOG.md * Raise CompilationException on duplicate model (#568) * Raise CompilationException on duplicate model Extend tests * Ignore disabled models in parse_sql_nodes Extend tests for duplicate model * Fix preexisting models * Use double quotes consistently Rename model-1 to model-disabled * Fix unit tests * Raise exception on duplicate model across packages Extend tests * Make run_started_at timezone aware (#553) (#556) * Make run_started_at timezone aware Set run_started_at timezone to UTC Enable timezone change in models Extend requirements Extend tests * Address comments from code review Create modules namespace to context Move pytz to modules Add new dependencies to setup.py * Add warning for missing constraints. Fixes #592 (#600) * Add warning for missing constraints. Fixes #592 * fix unit tests * fix schema tests used in, or defined in packages (#599) * fix schema tests used in, or defined in packages * don't hardcode dbt test namespace * fix/actually run tests * rm junk * run hooks in correct order, fixes #590 (#601) * run hooks in correct order, fixes #590 * add tests * fix tests * pep8 * change req for snowflake to fix crypto install issue (#612) From cffi callback <function _verify_callback at 0x06BF2978>: Traceback (most recent call last): File "c:\projects\dbt\.tox\pywin\lib\site-packages\OpenSSL\SSL.py", line 313, in wrapper _lib.X509_up_ref(x509) AttributeError: module 'lib' has no attribute 'X509_up_ref' From cffi callback <function _verify_callback at 0x06B8CF60>: * Update python version in Makefile from 3.5 to 3.6 (#613) * Fix/snowflake custom schema (#626) * Fixes already opened transaction issue For #602 * Fixes #621 * Create schema in archival flow (#625) * Fix for pre-hooks outside of transactions (#623) * Fix for pre-hooks outside of transactions #576 * improve tests * Fixes already opened transaction issue (#622) For #602 * Accept string for postgres port number (#583) (#624) * Accept string for postgres port number (#583) * s/str/basestring/g * print correct run time (include hooks) (#607) * add support for late binding views (Redshift) (#614) * add support for late binding views (Redshift) * fix bind logic * wip for get_columns_in_table * fix get_columns_in_table * fix for default value in bind config * pep8 * skip tests that depend on nonexistent or disabled models (#617) * skip tests that depend on nonexistent or disabled models * pep8, Fixes #616 * refactor * fix for adapter macro called within packages (#630) * fix for adapter macro called within packages * better error message * Update CHANGELOG.md (#632) * Update CHANGELOG.md * Update CHANGELOG.md * Bump version: 0.9.0 → 0.9.1 * more helpful exception for registry funcs * Rework deps to support local & git * pylint and cleanup * make modules directory first * Refactor registry client for cleanliness and better error handling * init converter script * create modules directory only if non-existent * Only check the hub registry for registry packages * Incorporate changes from Drew's branch Diff of original changes: https://github.com/fishtown-analytics/dbt/pull/591/files * lint * include a portion of the actual name in destination directory * Install dependencies using actual name; better exceptions * Error if two dependencies have same name * Process dependencies one level at a time Included in this change is a refactor of the deps run function for clarity. Also I changed the resolve_version function to update the object in place. I prefer the immutability of this function as it was, but the rest of the code doesn't really operate that way. And I ran into some bugs due to this discrepancy. * update var name * Provide support for repositories in project yml * Download files in a temp directory The downloads directory causes problems with the run command because this directory is not a dbt project. Need to download it elsewhere. * pin some versions * pep8-ify * some PR feedback changes around logging * PR feedback round 2 * Fix for redshift varchar bug (#647) * Fix for redshift varchar bug * pep8 on a sql string, smh * Set global variable overrides on the command line with --vars (#640) * Set global variable overrides on the command line with --vars * pep8 * integration tests for cli vars * Seed rewrite (#618) * loader for seed data files * Functioning rework of seed task * Make CompilerRunner fns private and impl. SeedRunner.compile Trying to distinguish between the public/private interface for this class. And the SeedRunner doesn't need the functionality in the compile function, it just needs a compile function to exist for use in the compilation process. * Test changes and fixes * make the DB setup script usable locally * convert simple copy test to use seeed * Fixes to get Snowflake working * New seed flag and make it non-destructive by default * Convert update SQL script to another seed * cleanup * implement bigquery csv load * context handling of StringIO * Better typing * strip seeder and csvkit dependency * update bigquery to use new data typing and to fix unicode issue * update seed test * fix abstract functions in base adapter * support time type * try pinning crypto, pyopenssl versions * remove unnecessary version pins * insert all at once, rather than one query per row * do not quote field names on creation * bad * quiet down parsedatetime logger * pep8 * UI updates + node conformity for seed nodes * add seed to list of resource types, cleanup * show option for CSVs * typo * pep8 * move agate import to avoid strange warnings * deprecation warning for --drop-existing * quote column names in seed files * revert quoting change (breaks Snowflake). Hush warnings * use hub url * Show installed version, silence semver regex warnings * sort versions to make tests deterministic. Prefer higher versions * pep8, fix comparison functions for py3 * make compare function return value in {-1, 0, 1} * fix for deleting git dirs on windows? * use system client rmdir instead of shutil directly * debug logging to identify appveyor issue * less restrictive error retry * rm debug logging * s/version/revision for git packages * more s/version/revision, deprecation cleanup * remove unused semver codepath * plus symlinks!!! * get rid of reference to removed function

* semver resolution * cleanup * remove unnecessary comment * add test for multiples on both sides * add resolve_to_specific_version * local registry * hacking out deps * Buck pkg mgmt (#645) * only load hooks and archives once (#540) * sets schema for node before parsing raw sql (#541) * Fix/env vars (#543) * fix for bad env_var exception * overwrite target with compiled values * fixes env vars, adds test. Auto-compile profile/target args * improvements for code that runs in hooks (#544) * improvements for code that runs in hooks * fix error message note * typo * Update CHANGELOG.md * bump version (#546) * add scope to service account json creds initializer (#547) * bump 0.9.0a3 --> 0.9.0a4 (#548) * Fix README links (#554) * Update README.md * handle empty profiles.yml file (#555) * return empty string (instead of None) to avoid polluting rendered sql (#566) * tojson was added in jinja 2.9 (#563) * tojson was added in jinja 2.9 * requirements * fix package-defined schema test macros (#562) * fix package-defined schema test macros * create a dummy Relation in parsing * fix for bq quoting (#565) * bump snowflake, remove pyasn1 (#570) * bump snowflake, remove pyasn1 * change requirements.txt * allow macros to return non-text values (#571) * revert jinja version, implement tojson hack (#572) * bump to 090a5 * update changelog * bump (#574) * 090 docs (#575) * 090 docs * Update CHANGELOG.md * Update CHANGELOG.md * Raise CompilationException on duplicate model (#568) * Raise CompilationException on duplicate model Extend tests * Ignore disabled models in parse_sql_nodes Extend tests for duplicate model * Fix preexisting models * Use double quotes consistently Rename model-1 to model-disabled * Fix unit tests * Raise exception on duplicate model across packages Extend tests * Make run_started_at timezone aware (#553) (#556) * Make run_started_at timezone aware Set run_started_at timezone to UTC Enable timezone change in models Extend requirements Extend tests * Address comments from code review Create modules namespace to context Move pytz to modules Add new dependencies to setup.py * Add warning for missing constraints. Fixes #592 (#600) * Add warning for missing constraints. Fixes #592 * fix unit tests * fix schema tests used in, or defined in packages (#599) * fix schema tests used in, or defined in packages * don't hardcode dbt test namespace * fix/actually run tests * rm junk * run hooks in correct order, fixes #590 (#601) * run hooks in correct order, fixes #590 * add tests * fix tests * pep8 * change req for snowflake to fix crypto install issue (#612) From cffi callback <function _verify_callback at 0x06BF2978>: Traceback (most recent call last): File "c:\projects\dbt\.tox\pywin\lib\site-packages\OpenSSL\SSL.py", line 313, in wrapper _lib.X509_up_ref(x509) AttributeError: module 'lib' has no attribute 'X509_up_ref' From cffi callback <function _verify_callback at 0x06B8CF60>: * Update python version in Makefile from 3.5 to 3.6 (#613) * Fix/snowflake custom schema (#626) * Fixes already opened transaction issue For #602 * Fixes #621 * Create schema in archival flow (#625) * Fix for pre-hooks outside of transactions (#623) * Fix for pre-hooks outside of transactions #576 * improve tests * Fixes already opened transaction issue (#622) For #602 * Accept string for postgres port number (#583) (#624) * Accept string for postgres port number (#583) * s/str/basestring/g * print correct run time (include hooks) (#607) * add support for late binding views (Redshift) (#614) * add support for late binding views (Redshift) * fix bind logic * wip for get_columns_in_table * fix get_columns_in_table * fix for default value in bind config * pep8 * skip tests that depend on nonexistent or disabled models (#617) * skip tests that depend on nonexistent or disabled models * pep8, Fixes #616 * refactor * fix for adapter macro called within packages (#630) * fix for adapter macro called within packages * better error message * Update CHANGELOG.md (#632) * Update CHANGELOG.md * Update CHANGELOG.md * Bump version: 0.9.0 → 0.9.1 * more helpful exception for registry funcs * Rework deps to support local & git * pylint and cleanup * make modules directory first * Refactor registry client for cleanliness and better error handling * init converter script * create modules directory only if non-existent * Only check the hub registry for registry packages * Incorporate changes from Drew's branch Diff of original changes: https://github.com/fishtown-analytics/dbt/pull/591/files * lint * include a portion of the actual name in destination directory * Install dependencies using actual name; better exceptions * Error if two dependencies have same name * Process dependencies one level at a time Included in this change is a refactor of the deps run function for clarity. Also I changed the resolve_version function to update the object in place. I prefer the immutability of this function as it was, but the rest of the code doesn't really operate that way. And I ran into some bugs due to this discrepancy. * update var name * Provide support for repositories in project yml * Download files in a temp directory The downloads directory causes problems with the run command because this directory is not a dbt project. Need to download it elsewhere. * pin some versions * pep8-ify * some PR feedback changes around logging * PR feedback round 2 * Fix for redshift varchar bug (#647) * Fix for redshift varchar bug * pep8 on a sql string, smh * Set global variable overrides on the command line with --vars (#640) * Set global variable overrides on the command line with --vars * pep8 * integration tests for cli vars * Seed rewrite (#618) * loader for seed data files * Functioning rework of seed task * Make CompilerRunner fns private and impl. SeedRunner.compile Trying to distinguish between the public/private interface for this class. And the SeedRunner doesn't need the functionality in the compile function, it just needs a compile function to exist for use in the compilation process. * Test changes and fixes * make the DB setup script usable locally * convert simple copy test to use seeed * Fixes to get Snowflake working * New seed flag and make it non-destructive by default * Convert update SQL script to another seed * cleanup * implement bigquery csv load * context handling of StringIO * Better typing * strip seeder and csvkit dependency * update bigquery to use new data typing and to fix unicode issue * update seed test * fix abstract functions in base adapter * support time type * try pinning crypto, pyopenssl versions * remove unnecessary version pins * insert all at once, rather than one query per row * do not quote field names on creation * bad * quiet down parsedatetime logger * pep8 * UI updates + node conformity for seed nodes * add seed to list of resource types, cleanup * show option for CSVs * typo * pep8 * move agate import to avoid strange warnings * deprecation warning for --drop-existing * quote column names in seed files * revert quoting change (breaks Snowflake). Hush warnings * use hub url * Show installed version, silence semver regex warnings * sort versions to make tests deterministic. Prefer higher versions * pep8, fix comparison functions for py3 * make compare function return value in {-1, 0, 1} * fix for deleting git dirs on windows? * use system client rmdir instead of shutil directly * debug logging to identify appveyor issue * less restrictive error retry * rm debug logging * s/version/revision for git packages * more s/version/revision, deprecation cleanup * remove unused semver codepath * plus symlinks!!! * get rid of reference to removed function automatic commit by git-black, original commits: 5fbcd12

drewbanin and others added 30 commits September 29, 2017 09:44

only load hooks and archives once (#540)

9f365eb

sets schema for node before parsing raw sql (#541)

fd17c2e

Fix/env vars (#543)

e40ed43

* fix for bad env_var exception * overwrite target with compiled values * fixes env vars, adds test. Auto-compile profile/target args

improvements for code that runs in hooks (#544)

c750ab9

* improvements for code that runs in hooks * fix error message note * typo

Update CHANGELOG.md

478f1e4

bump version (#546)

f2e8e8b

add scope to service account json creds initializer (#547)

cee92f5

bump 0.9.0a3 --> 0.9.0a4 (#548)

da941a3

Fix README links (#554)

969cc9b

Update README.md

fe477ae

handle empty profiles.yml file (#555)

b648b99

return empty string (instead of None) to avoid polluting rendered sql (…

c643ac9

…#566)

tojson was added in jinja 2.9 (#563)

3489e90

* tojson was added in jinja 2.9 * requirements

fix package-defined schema test macros (#562)

a552e3a

* fix package-defined schema test macros * create a dummy Relation in parsing * fix for bq quoting (#565)

bump snowflake, remove pyasn1 (#570)

fdf4a42

* bump snowflake, remove pyasn1 * change requirements.txt

allow macros to return non-text values (#571)

cc9c185

revert jinja version, implement tojson hack (#572)

c82d69f

bump to 090a5

9c05b6e

update changelog

e57a770

bump (#574)

e716cba

090 docs (#575)

c104fdb

* 090 docs * Update CHANGELOG.md

Update CHANGELOG.md

f039bb6

Add warning for missing constraints. Fixes #592 (#600)

1c7f64e

* Add warning for missing constraints. Fixes #592 * fix unit tests

fix schema tests used in, or defined in packages (#599)

ed60db0

* fix schema tests used in, or defined in packages * don't hardcode dbt test namespace * fix/actually run tests * rm junk

run hooks in correct order, fixes #590 (#601)

33da2db

* run hooks in correct order, fixes #590 * add tests * fix tests * pep8

Update python version in Makefile from 3.5 to 3.6 (#613)

6dbe79b

Fix/snowflake custom schema (#626)

323ab1e

* Fixes already opened transaction issue For #602 * Fixes #621

Buck Ryan added 3 commits January 30, 2018 17:23

Download files in a temp directory

af19831

The downloads directory causes problems with the run command because this directory is not a dbt project. Need to download it elsewhere.

pin some versions

da4f00b

pep8-ify

804ed71

drewbanin reviewed Feb 1, 2018

View reviewed changes

Buck Ryan added 2 commits February 2, 2018 14:47

some PR feedback changes around logging

922cca9

PR feedback round 2

a0ef6f6

cmcarthur reviewed Feb 2, 2018

View reviewed changes

drewbanin reviewed Feb 3, 2018

View reviewed changes

drewbanin and others added 15 commits February 9, 2018 20:33

Fix for redshift varchar bug (#647)

a1aa863

* Fix for redshift varchar bug * pep8 on a sql string, smh

Set global variable overrides on the command line with --vars (#640)

76098ea

* Set global variable overrides on the command line with --vars * pep8 * integration tests for cli vars

use hub url

bcca97a

Merge branch 'development' into buck-pkg-mgmt

6249040

Merge branch 'buck-pkg-mgmt' of github.com:fishtown-analytics/dbt int…

5574b24

…o buck-pkg-mgmt

Show installed version, silence semver regex warnings

8476fec

sort versions to make tests deterministic. Prefer higher versions

b79bce0

pep8, fix comparison functions for py3

50ebdda

make compare function return value in {-1, 0, 1}

736792c

fix for deleting git dirs on windows?

81e4dd6

use system client rmdir instead of shutil directly

12f3cd6

debug logging to identify appveyor issue

2d88fb9

less restrictive error retry

ae5b75d

rm debug logging

b8acf3b

drewbanin merged commit 4e2cb40 into package-management Feb 27, 2018

drewbanin deleted the buck-pkg-mgmt branch February 27, 2018 00:14

drewbanin added this to the 0.9.2 milestone Mar 2, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Buck pkg mgmt #645

Buck pkg mgmt #645

b-ryan commented Jan 29, 2018

drewbanin left a comment

drewbanin Feb 1, 2018

b-ryan Feb 2, 2018

drewbanin Feb 3, 2018

b-ryan Feb 5, 2018

drewbanin Feb 5, 2018

drewbanin Feb 1, 2018

b-ryan Feb 2, 2018

drewbanin Feb 2, 2018

drewbanin Feb 1, 2018

b-ryan Feb 2, 2018

drewbanin Feb 1, 2018

drewbanin Feb 1, 2018

b-ryan Feb 2, 2018

drewbanin Feb 2, 2018

drewbanin Feb 1, 2018

b-ryan Feb 2, 2018 •

edited

Loading

drewbanin Feb 3, 2018

drewbanin Feb 1, 2018

drewbanin Feb 1, 2018

b-ryan Feb 2, 2018

b-ryan Feb 2, 2018

drewbanin Feb 1, 2018

cmcarthur Feb 2, 2018

drewbanin Feb 3, 2018

b-ryan Feb 5, 2018

drewbanin Feb 5, 2018

drewbanin Feb 26, 2018

drewbanin commented Feb 3, 2018

drewbanin commented Feb 12, 2018

		index_cached = memoized(index)


		def packages(registry_base_url=None):

Buck pkg mgmt #645

Buck pkg mgmt #645

Conversation

b-ryan commented Jan 29, 2018

drewbanin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

b-ryan Feb 2, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

drewbanin commented Feb 3, 2018

drewbanin commented Feb 12, 2018

b-ryan Feb 2, 2018 •

edited

Loading