Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT 2516 ensure that paths in Jinja context flags object are strings #7678

Merged
merged 3 commits into from
May 24, 2023
Merged

CT 2516 ensure that paths in Jinja context flags object are strings #7678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f0247f
Stringify paths in flags
gshank May 22, 2023
66745f1
Changie
gshank May 22, 2023
b2dbc40
mising import
gshank May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20230522-135007.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Stringify flag paths for Jinja context
time: 2023-05-22T13:50:07.897354-04:00
custom:
Author: gshank
Issue: "7495"
3 changes: 3 additions & 0 deletions core/dbt/flags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from argparse import Namespace
from multiprocessing import get_context
from typing import Optional
from pathlib import Path


# for setting up logger for legacy logger
Expand Down Expand Up @@ -95,6 +96,8 @@ def get_flag_dict():
def get_flag_obj():
new_flags = Namespace()
for key, val in get_flag_dict().items():
if isinstance(val, Path):
val = str(val)
setattr(new_flags, key.upper(), val)
# The following 3 are CLI arguments only so they're not full-fledged flags,
# but we put in flags for users.
Expand Down