-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move --profile
and --target
to global config
#7920
feat: move --profile
and --target
to global config
#7920
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @rexledesma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for contributing!
There's an opportunity to simplify the code, but I'll leave whether to do it up to you.
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @rexledesma |
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @rexledesma |
@rexledesma thanks for submitting this so quickly! 🤩 Could you fill out this super short and easy form? It's a one-time requirement for all our contributors. Once you do that, then we can make make the CLA Bot happy 😎 |
@cla-bot check |
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @rexledesma |
The cla-bot has been summoned, and re-checked this pull request! |
@rexledesma Are you happy for me to reopen this PR at some point and use your code as a starting point/solution? I have a signed CLA |
@barton996 I'll create a quick starting point for you and share with you here in a few minutes. |
Thanks for picking this up @barton996! You can use these commits from my It shows how to do the first two bullet points here. You'd then need to do this part (which is the most time-consuming):
Finally, you'd need to run |
@dbeatty10 Cheers I'll take a look when I get a chance |
Resolves #7798.
Description
Move
--target
and--profile
command line flags to global config. Also, allow these flags to be set by environment variable (DBT_TARGET
, andDBT_PROFILE
).Checklist
changie new
to create a changelog entry