[CT-1483] Backport #8181 to 1.6.latest #8196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterallenwebb
approved these changes
Jul 24, 2023
Previously we were checking if a macro included a materialization based on if the macro name included the word `materialization`. However, a macro name included the word `materialization` isn't guarnteed to actually have a materialization, and a macro that doesn't have `materialization` in the name isn't guaranteed to not have a materialization. This change is to detect macros with materializations based on the detected block type of the macro.
QMalcolm
force-pushed
the
ct-1483--backport-1.6.latest
branch
from
adae0b1 to
4e2f076
Compare
martynydbt
approved these changes
Jul 25, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of approved and merged #8181 to 1.6.latest. There's currently an issue which is stopping people from upgrading (and has been since 1.3) wherein macros that included the word
materializationin their name, but didn't actually contain a materialization, caused an exception to be thrown. More details can be seen in CT-1483.This backport was done by cherry-picking from the #8181 PR branch. Specifically
git cherry-pick 68df0f9753e9a41a2b91064a6851af7f3366af36^..3bf17598ee09254a2e0dcda398d9ee8248f3fa46. No merge conflicts occurred, so no conflict resolutions were necessary.Checklist