-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loosen the click pin #8232
loosen the click pin #8232
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov Report
@@ Coverage Diff @@
## main #8232 +/- ##
=======================================
Coverage 86.18% 86.18%
=======================================
Files 174 174
Lines 25511 25511
=======================================
+ Hits 21986 21987 +1
+ Misses 3525 3524 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the reason we were pinning in the first place is removed so the change looks good to me
* loosen the click pin * changelog * separate out sqlparse pin * remove changelog * add ignores (cherry picked from commit 5b6d21d)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-8232-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5b6d21d7da00847e694111e21724a59053b36e76
# Push it to GitHub
git push --set-upstream origin backport-8232-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest Then, create a pull request where the |
* loosen the click pin * changelog * separate out sqlparse pin * remove changelog * add ignores
resolves #8145
docs dbt-labs/docs.getdbt.com/#Problem
click pin is too restrictive
Solution
pin
click<9
Checklist