-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quoting for sync all columns #8914
Add quoting for sync all columns #8914
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Dmitri Tchebotarev.
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
770c693
to
d0e7d02
Compare
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @DTchebotarev |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main dbt-labs/dbt-core#8914 +/- ##
==========================================
- Coverage 86.36% 86.31% -0.05%
==========================================
Files 177 177
Lines 26385 26385
==========================================
- Hits 22787 22775 -12
- Misses 3598 3610 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for taking the time to open this PR @DTchebotarev! Since opening, we've decoupled dbt Adapters from dbt Core, and this code now lives in a separate repo: dbt-adapters. A consequence of the decoupling is that PR can't be merged anymore as is, so we're closing it. For more context see #9171. The linked issue has already been transferred. Please don't hesitate to re-open your proposed code changes within this PR in the dbt-adapters repo. |
Resolves dbt-labs/dbt-adapters#160
Resolves dbt-labs/dbt-adapters#63
Partial fix for dbt-labs/dbt-adapters#160, sounds like it will need follow up PRs in specific adapter repos (e.g. snowflake adatper)
Problem
When the
sync_all_columns
incremental option is used, the columns that are added and dropped are not quoted. This means that DBT will throw an error if the columns to be added or dropped have spaces or other unconventional names which require quotes.Solution
Add
adapter.quote()
around column names.Checklist