Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typing-extensions version to >=4.4 #9012

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

tlento
Copy link
Contributor

@tlento tlento commented Nov 6, 2023

resolves #7828

Problem

With the addition of dbt-semantic-interfaces as a package dependency
for dbt-core we added an implicit requirement that the local install
of typing-extensions be for a version >= 4.4. This means, effective
with dbt-core 1.6, our version minimum for typing-extensions has been
updated to 4.4.

This caused issues in certain install environments due to virtual envs with
pre-installs of out of date packages. While that has been addressed with
a patch update of dbt-semantic-interfaces, we should still have the correct
dependencies listed in dbt-core as well.

Solution

The solution is to just update the verison.

This change reflects the reality imposed on us by our dependency hierarchy.
Happily, mashumaro previously boosted its base version dependency to 4.1
some time ago, and effective with major version 4 the typing-extensions
package maintainers have committed to strictly following SemVer, so this
should be a low risk minimum version change.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Nov 6, 2023
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7c3ac8) 86.50% compared to head (e8242cc) 86.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9012      +/-   ##
==========================================
- Coverage   86.50%   86.46%   -0.05%     
==========================================
  Files         179      179              
  Lines       26508    26508              
==========================================
- Hits        22932    22920      -12     
- Misses       3576     3588      +12     
Flag Coverage Δ
integration 83.28% <ø> (-0.11%) ⬇️
unit 64.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/setup.py 0.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

With the addition of dbt-semantic-interfaces as a package dependency
for dbt-core we added an implicit requirement that the local install
of typing-extensions be for a version >= 4.4. This means, effective
with dbt-core 1.6, our version minimum for typing-extensions has been
updated to 4.4.

This change reflects the reality imposed on us by our dependency hierarchy.
Happily, mashumaro previously boosted its base version dependency to 4.1
some time ago, and effective with major version 4 the typing-extensions
package maintainers have committed to strictly following SemVer, so this
should be a low risk minimum version change.
@tlento tlento force-pushed the update-typing-extensions-bound branch from fd8a28c to e8242cc Compare November 6, 2023 21:02
@tlento tlento marked this pull request as ready for review November 6, 2023 21:32
@tlento tlento requested a review from a team as a code owner November 6, 2023 21:32
@tlento tlento requested a review from peterallenwebb November 6, 2023 21:32
@tlento
Copy link
Contributor Author

tlento commented Nov 6, 2023

Note - we may choose to backport this to 1.6 and 1.7, but it's not necessary, as all new installs of 1.6 and 1.7 will naturally pick up the changes from dbt-semantic-interfaces.

@@ -73,7 +73,6 @@
# These are major-version-0 packages also maintained by dbt-labs. Accept patches.
"dbt-extractor~=0.5.0",
"minimal-snowplow-tracker~=0.0.2",
# DSI is under active development, so we're pinning to specific dev versions for now.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for removing this!

@MichelleArk MichelleArk merged commit e547c0e into main Nov 8, 2023
48 checks passed
@MichelleArk MichelleArk deleted the update-typing-extensions-bound branch November 8, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2672] [Bug] Cannot import name 'Unpack' from 'typing_extensions' (dbt-core 1.5.1)
3 participants