Fix #8652: Use seed file from disk for unit testing if rows not specified in YAML config #9064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## unit_testing_feature_branch #9064 +/- ##
===============================================================
- Coverage 86.82% 86.79% -0.04%
===============================================================
Files 181 181
Lines 27107 27126 +19
===============================================================
+ Hits 23537 23543 +6
- Misses 3570 3583 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aranke
requested review from
gshank,
emmyoop and
MichelleArk
and removed request for
QMalcolm
aranke
changed the title
MichelleArk
reviewed
Nov 14, 2023
MichelleArk
reviewed
Nov 14, 2023
MichelleArk
reviewed
Nov 14, 2023
MichelleArk
reviewed
Nov 14, 2023
MichelleArk
reviewed
Nov 14, 2023
MichelleArk
reviewed
Nov 14, 2023
MichelleArk
reviewed
Nov 14, 2023
MichelleArk
reviewed
Nov 14, 2023
MichelleArk
reviewed
Nov 14, 2023
MichelleArk
reviewed
Nov 14, 2023
|
@MichelleArk I think I addressed all your comments above, ready for re-review. Thanks! |
MichelleArk
reviewed
Nov 14, 2023
MichelleArk
reviewed
Nov 14, 2023
|
I am not sure why the log schema is failing in CI, investigating. |
MichelleArk
reviewed
Nov 14, 2023
|
@MichelleArk Addressed second round of comments, thanks for the detailed feedback! |
MichelleArk
reviewed
Nov 15, 2023
MichelleArk
reviewed
Nov 15, 2023
MichelleArk
approved these changes
Nov 15, 2023
gshank
added a commit
that referenced
this pull request
Jan 16, 2024
* Initial implementation of unit testing (from pr #2911) Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com> * 8295 unit testing artifacts (#8477) * unit test config: tags & meta (#8565) * Add additional functional test for unit testing selection, artifacts, etc (#8639) * Enable inline csv format in unit testing (#8743) * Support unit testing incremental models (#8891) * update unit test key: unit -> unit-tests (#8988) * convert to use unit test name at top level key (#8966) * csv file fixtures (#9044) * Unit test support for `state:modified` and `--defer` (#9032) Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com> * Allow use of sources as unit testing inputs (#9059) * Use daff for diff formatting in unit testing (#8984) * Fix #8652: Use seed file from disk for unit testing if rows not specified in YAML config (#9064) Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com> Fix #8652: Use seed value if rows not specified * Move unit testing to test and build commands (#9108) * Enable unit testing in non-root packages (#9184) * convert test to data_test (#9201) * Make fixtures files full-fledged members of manifest and enable partial parsing (#9225) * In build command run unit tests before models (#9273) --------- Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com> Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com> Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: Kshitij Aranke <kshitij.aranke@dbtlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8652
Problem
Seed values must be specified for unit testing.
Solution
Read seed from disk if no rows are specified in YAML config, instead of throwing an error.
Checklist