Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #9147 to 1.7.latest #9156

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

jtcohen6
Copy link
Contributor

Resolves errors related to package-lock.yml file:

  • Lock git packages to specific commit SHA revision
  • Use PackageRenderer to reread

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

* Update git revision with commit SHA

* Use PackageRenderer for lock file

* add unit tests for git and tarball packages

* deepcopy unrendered_packages_data before iteration, fix remaining tests

* Add functional tests

* Add changelog entries

* Assert one more

---------

Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com>
@jtcohen6 jtcohen6 requested a review from a team as a code owner November 28, 2023 09:53
@cla-bot cla-bot bot added the cla:yes label Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f94bf2b) 86.64% compared to head (a2b5bb7) 86.61%.

Files Patch % Lines
core/dbt/deps/tarball.py 85.71% 2 Missing ⚠️
core/dbt/deps/git.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           1.7.latest    #9156      +/-   ##
==============================================
- Coverage       86.64%   86.61%   -0.03%     
==============================================
  Files             179      179              
  Lines           26542    26572      +30     
==============================================
+ Hits            22996    23015      +19     
- Misses           3546     3557      +11     
Flag Coverage Δ
integration 83.46% <86.95%> (-0.06%) ⬇️
unit 64.98% <78.26%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtcohen6 jtcohen6 merged commit 09f5bb3 into 1.7.latest Nov 29, 2023
51 checks passed
@jtcohen6 jtcohen6 deleted the jerco/backport-9147-to-1.7 branch November 29, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants