adding clean_up methods to basic and unique_id tests #9195

McKnight-42 · 2023-12-01T20:44:59Z

resolves #9219, dbt-redshift- dbt-labs/dbt-redshift#675

Problem

found in dbt-redshift but possibly extending to all adapters some hanging artifacts found in tests imported from core within the test_basic and incremental_unique_id files.

Solution

testing if adding cleanup methods to try and guarantee dropping of schemas post test runs

Testing Process

after adding the cleanup methods I went and clear out redshift in postico and ran the tests locally several times in multi and single thread on Thursday/Friday of last week to test for other hanging artifacts and see make sure they were catching correct allocations.
on Monday 12/3 I again checked postico on redshift to get idea of level of build up over a few days and cleared and re tested, then went and cleared out bigquery as well and tested there.

after conversation around docs_genreate test failure I am again testing adapters
dbt-redshift seems to behave as expected in local multi-thread runs ✅
dbt-redshift local single thread ✅
ci/cd test draft pr: dbt-labs/dbt-redshift#683 (ran 3.8 integration test twice and both times ended no hanging artifacts) ✅

dbt-bigquery local mulit-thread ✅
dbt-bigquery local single thread ✅
dbt-bigquery draft pr for ci/.cd run dbt-labs/dbt-bigquery#1049 ✅

Checklist

I have read the contributing guide and understand what's expected of me
I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
This PR includes type annotations for new and modified functions

github-actions · 2023-12-01T20:45:16Z

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

codecov · 2023-12-01T20:47:38Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1740df5) 86.71% compared to head (a540954) 86.65%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9195      +/-   ##
==========================================
- Coverage   86.71%   86.65%   -0.06%     
==========================================
  Files         179      179              
  Lines       26652    26648       -4     
==========================================
- Hits        23110    23092      -18     
- Misses       3542     3556      +14

Flag	Coverage Δ
integration	`83.53% <ø> (-0.12%)`	⬇️
unit	`65.10% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

McKnight-42 · 2023-12-04T22:49:31Z

PR discussion:

Is there any further level of testing we want to do before approval?
Is this something we want to become a catch-all for other possible hanging tests in other databases?

test failure

colin-rogers-dbt · 2023-12-06T00:37:15Z

tests/adapter/dbt/tests/adapter/basic/test_docs_generate.py

@@ -404,6 +404,22 @@ def project_config_update(self, unique_schema):
            },
        }

+    @pytest.fixture(autouse=True)


Looks like this might have broken the docs tests? https://github.com/dbt-labs/dbt-core/actions/runs/7065010846/job/19307239764?pr=9195#step:8:432

Could be an inter-test dependency (i.e. docs generate was relying on some artifacts not being cleaned up)

going to try and swap over to specifying unqiue_schema instead of test_schema in clean_up method and see if that fixes it test_schema should ideally be being picked up by the default teardown method we have designed anyway.

if that doesn't work I may try moving the clean_up method down into BaseDocsGenerate instead of BaseGenerateProject which may be more appropriate anyway. Though that would mean we need to make a new clean_up method for BaseDocsGenReferences potentially as it doesn't inherit from BaseDocsGenerate

…ing-teardown

…breakage on docs_generate test

…rt of project_config

colin-rogers-dbt · 2023-12-06T18:07:12Z

Is this something we want to become a catch-all for other possible hanging tests in other databases?

I believe so but I think we can merge this and see if other tests also need it

Is there any further level of testing we want to do before approval?

Have we run this branch against other adapter integration tests?

McKnight-42 · 2023-12-06T18:09:35Z

Is there any further level of testing we want to do before approval?

Have we run this branch against other adapter integration tests?

I haven't since making changes to the docs_generate test was just wrapping up testing that in core ci/cd as the tests weren't failing locally

previously I have tested the additions against bigquery, and redshift was going to do that again this afternoon to make sure changes isn't causing something to be missed once it was passing in core again.

emmyoop

Generally looks good. I have comments on 2 files.

Can you also add some notes to #9111 so we track this on a larger scale?

emmyoop · 2023-12-11T21:55:34Z

tests/functional/artifacts/data/state/v12/manifest.json

Why do these changes require manifest changes?

honestly, this seemed to change every time I did a git add . i didn't manually change anything in it. @emmyoop any ideas as to why it would of updated?

Oh no! That's because this line is uncommented! It should be commented out. Looks like it got accidentally merged.

Can you comment it out and delete your manifest generated?

okay after deleting the line, and the manifest we would have some failures in the test for not having a manifest to compare to so I grabbed the one generated from the above pr.

Sorry, by "delete your generated manifest" I meant to revert the changes.

Can you revert the file instead of generating a new one?

I can try i just copy/pasted it from Quigley's pr

emmyoop · 2023-12-11T21:56:47Z

.changes/unreleased/Under the Hood-20231211-112858.yaml

Changes to just tests should not have a changelog.

…anges created

…ifest.json to appease test

This reverts commit a755419.

emmyoop

Looks good.

* moving types_pb2.py to common/events * Update parser to support conversion metrics (#9173) * added ConversionTypeParams classes * updated parser for ConversionTypeParams * added step to populate input_measure for conversion metrics * version bump on DSI * comment back manifest generating line * updated v12 schemas * added tests * added changelog * Remove `--dry-run` flag from `dbt deps` (#9169) * Rm --dry-run flag for dbt deps * Add changelog entry * Update test * PR feedback * adding clean_up methods to basic and unique_id tests (#9195) * init attempt of adding clean_up methods to basic and unique_id tests * swapping cleanup method drop of test_schema to unique_schema to test breakage on docs_generate test * moving the clean_up method down into class BaseDocsGenerate * remove drop relation for unique_schema * manually define alternate_schema for clean_up as not being seen as part of project_config * add changelog * remove unneeded changelog * uncomment line that generates new manifest and delete manifest our changes created * make sure the manifest test is deleted and readd older version of manifest.json to appease test * manually revert file to previous commit * Revert "manually revert file to previous commit" This reverts commit a755419. --------- Co-authored-by: William Deng <33618746+WilliamDee@users.noreply.github.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>

* Update parser to support conversion metrics (#9173) * added ConversionTypeParams classes * updated parser for ConversionTypeParams * added step to populate input_measure for conversion metrics * version bump on DSI * comment back manifest generating line * updated v12 schemas * added tests * added changelog * Remove `--dry-run` flag from `dbt deps` (#9169) * Rm --dry-run flag for dbt deps * Add changelog entry * Update test * PR feedback * adding clean_up methods to basic and unique_id tests (#9195) * init attempt of adding clean_up methods to basic and unique_id tests * swapping cleanup method drop of test_schema to unique_schema to test breakage on docs_generate test * moving the clean_up method down into class BaseDocsGenerate * remove drop relation for unique_schema * manually define alternate_schema for clean_up as not being seen as part of project_config * add changelog * remove unneeded changelog * uncomment line that generates new manifest and delete manifest our changes created * make sure the manifest test is deleted and readd older version of manifest.json to appease test * manually revert file to previous commit * Revert "manually revert file to previous commit" This reverts commit a755419. --------- Co-authored-by: William Deng <33618746+WilliamDee@users.noreply.github.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>

* remove dbt.contracts.connection imports from adapter module * Move events to common (#8676) * Move events to common * More Type Annotations (#8536) * Extend use of type annotations in the events module. * Add return type of None to more __init__ definitions. * Still more type annotations adding -> None to __init__ * Tweak per review * Allow adapters to include python package logging in dbt logs (#8643) * add set_package_log_level functionality * set package handler * set package handler * add logging about stting up logging * test event log handler * add event log handler * add event log level * rename package and add unit tests * revert logfile config change * cleanup and add code comments * add changie * swap function for dict * add additional unit tests * fix unit test * update README and protos * fix formatting * update precommit --------- Co-authored-by: Peter Webb <peter.webb@dbtlabs.com> * fix import * move types_pb2.py from events to common/events * move agate_helper into common * Add utils module (#8910) * moving types_pb2.py to common/events * split out utils into core/common/adapters * add changie * remove usage of dbt.config.PartialProject from dbt/adapters (#8909) * remove usage of dbt.config.PartialProject from dbt/adapters * add changie --------- Co-authored-by: Colin <colin.rogers@dbtlabs.com> * move agate_helper unit tests under tests/unit/common * move agate_helper into common (#8911) * move agate_helper into common * add changie --------- Co-authored-by: Colin <colin.rogers@dbtlabs.com> * remove dbt.flags.MP_CONTEXT usage in dbt/adapters (#8931) * remove dbt.flags.LOG_CACHE_EVENTS usage in dbt/adapters (#8933) * Refactor Base Exceptions (#8989) * moving types_pb2.py to common/events * Refactor Base Exceptions * update make_log_dir_if_missing to handle str * move remaining adapters exception imports to common/adapters --------- Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com> * Remove usage of dbt.deprecations in dbt/adapters, enable core & adapter-specific (#9051) * Decouple adapter constraints from core (#9054) * Move constraints to dbt.common * Move constraints to contracts folder, per review * Add a changelog entry. * move include/global_project to adapters (#8930) * remove adapter.get_compiler (#9134) * Move adapter logger to adapters (#9165) * moving types_pb2.py to common/events * Move AdapterLogger to adapter folder * add changie * delete accidentally merged types_pb2.py * Move the semver package to common and alter references. (#9166) * Move the semver package to common and alter references. * Alter leftover references to dbt.semver, this time using from syntax. --------- Co-authored-by: Mila Page <versusfacit@users.noreply.github.com> * Refactor EventManager setup and interaction (#9180) * moving types_pb2.py to common/events * move event manager setup back to core, remove ref to global EVENT_MANAGER and clean up event manager functions * move invocation_id from events to first class common concept * move lowercase utils to common * move lowercase utils to common * ref CAPTURE_STREAM through method * add changie * first pass: adapter migration script (#9160) * Decouple macro generator from adapters (#9149) * Remove usage of dbt.contracts.relation in dbt/adapters (#9207) * Remove ResultNode usage from connections (#9211) * Add RelationConfig Protocol for use in Relation.create_from (#9210) * move relation contract to dbt.adapters * changelog entry * first pass: clean up relation.create_from * type ignores * type ignore * changelog entry * update RelationConfig variable names * Merge main into feature/decouple-adapters-from-core (#9240) * moving types_pb2.py to common/events * Restore warning on unpinned git packages (#9157) * Support --empty flag for schema-only dry runs (#8971) * Fix ensuring we produce valid jsonschema artifacts for manifest, catalog, sources, and run-results (#9155) * Drop `all_refs=True` from jsonschema-ization build process Passing `all_refs=True` makes it so that Everything is a ref, even the top level schema. In jsonschema land, this essentially makes the produced artifact not a full schema, but a fractal object to be included in a schema. Thus when `$id` is passed in, jsonschema tools blow up because `$id` is for identifying a schema, which we explicitly weren't creating. The alternative was to drop the inclusion of `$id`. Howver, we're intending to create a schema, and having an `$id` is recommended best practice. Additionally since we were intending to create a schema, not a fractal, it seemed best to create to full schema. * Explicity produce jsonschemas using DRAFT_2020_12 dialect Previously were were implicitly using the `DRAFT_2020_12` dialect through mashumaro. It felt wise to begin explicitly specifying this. First, it is closest in available mashumaro provided dialects to what we produced pre 1.7. Secondly, if mashumaro changes its default for whatever reason (say a new dialect is added, and mashumaro moves to that), we don't want to automatically inherit that. * Bump manifest version to v12 Core 1.7 released with manifest v11, and we don't want to be overriding that with 1.8. It'd be weird for 1.7 and 1.8 to both have v11 manifests, but for them to be different, right? * Begin including schema dialect specification in produced jsonschema In jsonschema's documentation they state > It's not always easy to tell which draft a JSON Schema is using. > You can use the $schema keyword to declare which version of the JSON Schema specification the schema is written to. > It's generally good practice to include it, though it is not required. and > For brevity, the $schema keyword isn't included in most of the examples in this book, but it should always be used in the real world. Basically, to know how to parse a schema, it's important to include what schema dialect is being used for the schema specification. The change in this commit ensures we include that information. * Create manifest v12 jsonschema specification * Add change documentation for jsonschema schema production fix * Bump run-results version to v6 * Generate new v6 run-results jsonschema * Regenerate catalog v1 and sources v3 with fixed jsonschema production * Update tests to handle bumped versions of manifest and run-results --------- Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com> Co-authored-by: Quigley Malcolm <QMalcolm@users.noreply.github.com> * Move BaseConfig to Common (#9224) * moving types_pb2.py to common/events * move BaseConfig and assorted dependencies to common * move ShowBehavior and OnConfigurationChange to common * add changie * Remove manifest from catalog and connection method signatures (#9242) * Add MacroResolverProtocol, remove lazy loading of manifest in adapter.execute_macro (#9243) * remove manifest from adapter.execute_macro, replace with MacroResolver + remove lazy loading * rename to MacroResolverProtocol * pass MacroResolverProtcol in adapter.calculate_freshness_from_metadata * changelog entry * fix adapter.calculate_freshness call * pass context to MacroQueryStringSetter (#9248) * moving types_pb2.py to common/events * remove manifest from adapter.execute_macro, replace with MacroResolver + remove lazy loading * rename to MacroResolverProtocol * pass MacroResolverProtcol in adapter.calculate_freshness_from_metadata * changelog entry * fix adapter.calculate_freshness call * pass context to MacroQueryStringSetter * changelog entry --------- Co-authored-by: Colin <colin.rogers@dbtlabs.com> * add macro_context_generator on adapter (#9251) * moving types_pb2.py to common/events * remove manifest from adapter.execute_macro, replace with MacroResolver + remove lazy loading * rename to MacroResolverProtocol * pass MacroResolverProtcol in adapter.calculate_freshness_from_metadata * changelog entry * fix adapter.calculate_freshness call * add macro_context_generator on adapter * fix adapter test setup * changelog entry * Update parser to support conversion metrics (#9173) * added ConversionTypeParams classes * updated parser for ConversionTypeParams * added step to populate input_measure for conversion metrics * version bump on DSI * comment back manifest generating line * updated v12 schemas * added tests * added changelog * Add typing for macro_context_generator, fix query_header_context --------- Co-authored-by: Colin <colin.rogers@dbtlabs.com> Co-authored-by: William Deng <33618746+WilliamDee@users.noreply.github.com> * Pass mp_context to adapter factory (#9275) * moving types_pb2.py to common/events * require core to pass mp_context to adapter factory * add changie * fix SpawnContext annotation * Fix include for decoupling (#9286) * moving types_pb2.py to common/events * fix include path in MANIFEST.in * Fix include for decoupling (#9288) * moving types_pb2.py to common/events * fix include path in MANIFEST.in * add index.html to in MANIFEST.in * move system client to common (#9294) * moving types_pb2.py to common/events * move system.py to common * add changie update README * remove dbt.utils from semver.py * remove aliasing connection_exception_retry * Update materialized views to use RelationConfigs and remove refs to dbt.utils (#9291) * moving types_pb2.py to common/events * add AdapterRuntimeConfig protocol and clean up dbt-postgress core imports * add changie * remove AdapterRuntimeConfig * update changelog * Add config field to RelationConfig (#9300) * moving types_pb2.py to common/events * add config field to RelationConfig * merge main into feature/decouple-adapters-from-core (#9305) * moving types_pb2.py to common/events * Update parser to support conversion metrics (#9173) * added ConversionTypeParams classes * updated parser for ConversionTypeParams * added step to populate input_measure for conversion metrics * version bump on DSI * comment back manifest generating line * updated v12 schemas * added tests * added changelog * Remove `--dry-run` flag from `dbt deps` (#9169) * Rm --dry-run flag for dbt deps * Add changelog entry * Update test * PR feedback * adding clean_up methods to basic and unique_id tests (#9195) * init attempt of adding clean_up methods to basic and unique_id tests * swapping cleanup method drop of test_schema to unique_schema to test breakage on docs_generate test * moving the clean_up method down into class BaseDocsGenerate * remove drop relation for unique_schema * manually define alternate_schema for clean_up as not being seen as part of project_config * add changelog * remove unneeded changelog * uncomment line that generates new manifest and delete manifest our changes created * make sure the manifest test is deleted and readd older version of manifest.json to appease test * manually revert file to previous commit * Revert "manually revert file to previous commit" This reverts commit a755419. --------- Co-authored-by: William Deng <33618746+WilliamDee@users.noreply.github.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com> * resolve merge conflict on unparsed.py (#9309) * moving types_pb2.py to common/events * Update parser to support conversion metrics (#9173) * added ConversionTypeParams classes * updated parser for ConversionTypeParams * added step to populate input_measure for conversion metrics * version bump on DSI * comment back manifest generating line * updated v12 schemas * added tests * added changelog * Remove `--dry-run` flag from `dbt deps` (#9169) * Rm --dry-run flag for dbt deps * Add changelog entry * Update test * PR feedback * adding clean_up methods to basic and unique_id tests (#9195) * init attempt of adding clean_up methods to basic and unique_id tests * swapping cleanup method drop of test_schema to unique_schema to test breakage on docs_generate test * moving the clean_up method down into class BaseDocsGenerate * remove drop relation for unique_schema * manually define alternate_schema for clean_up as not being seen as part of project_config * add changelog * remove unneeded changelog * uncomment line that generates new manifest and delete manifest our changes created * make sure the manifest test is deleted and readd older version of manifest.json to appease test * manually revert file to previous commit * Revert "manually revert file to previous commit" This reverts commit a755419. --------- Co-authored-by: William Deng <33618746+WilliamDee@users.noreply.github.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com> * Resolve unparsed.py conflict (#9311) * Update parser to support conversion metrics (#9173) * added ConversionTypeParams classes * updated parser for ConversionTypeParams * added step to populate input_measure for conversion metrics * version bump on DSI * comment back manifest generating line * updated v12 schemas * added tests * added changelog * Remove `--dry-run` flag from `dbt deps` (#9169) * Rm --dry-run flag for dbt deps * Add changelog entry * Update test * PR feedback * adding clean_up methods to basic and unique_id tests (#9195) * init attempt of adding clean_up methods to basic and unique_id tests * swapping cleanup method drop of test_schema to unique_schema to test breakage on docs_generate test * moving the clean_up method down into class BaseDocsGenerate * remove drop relation for unique_schema * manually define alternate_schema for clean_up as not being seen as part of project_config * add changelog * remove unneeded changelog * uncomment line that generates new manifest and delete manifest our changes created * make sure the manifest test is deleted and readd older version of manifest.json to appease test * manually revert file to previous commit * Revert "manually revert file to previous commit" This reverts commit a755419. --------- Co-authored-by: William Deng <33618746+WilliamDee@users.noreply.github.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com> --------- Co-authored-by: colin-rogers-dbt <111200756+colin-rogers-dbt@users.noreply.github.com> Co-authored-by: Peter Webb <peter.webb@dbtlabs.com> Co-authored-by: Colin <colin.rogers@dbtlabs.com> Co-authored-by: Mila Page <67295367+VersusFacit@users.noreply.github.com> Co-authored-by: Mila Page <versusfacit@users.noreply.github.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: Quigley Malcolm <QMalcolm@users.noreply.github.com> Co-authored-by: William Deng <33618746+WilliamDee@users.noreply.github.com> Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com> Co-authored-by: Chenyu Li <chenyu.li@dbtlabs.com>

init attempt of adding clean_up methods to basic and unique_id tests

2bb45d1

McKnight-42 self-assigned this Dec 1, 2023

cla-bot bot added the cla:yes label Dec 1, 2023

McKnight-42 changed the title ~~init attempt of adding clean_up methods to basic and unique_id tests~~ adding clean_up methods to basic and unique_id tests Dec 1, 2023

McKnight-42 marked this pull request as ready for review December 4, 2023 22:40

McKnight-42 requested a review from a team as a code owner December 4, 2023 22:40

McKnight-42 requested review from mikealfare, ChenyuLInx and colin-rogers-dbt and removed request for a team and mikealfare December 4, 2023 22:41

colin-rogers-dbt previously approved these changes Dec 5, 2023

View reviewed changes

colin-rogers-dbt reviewed Dec 6, 2023

View reviewed changes

McKnight-42 added 2 commits December 6, 2023 00:46

Merge branch 'main' of github.com:dbt-labs/dbt into mcknight/test-add…

c004072

…ing-teardown

swapping cleanup method drop of test_schema to unique_schema to test …

8b6fa32

…breakage on docs_generate test

McKnight-42 requested a review from colin-rogers-dbt December 6, 2023 16:05

McKnight-42 marked this pull request as draft December 6, 2023 16:05

McKnight-42 added 3 commits December 6, 2023 10:16

moving the clean_up method down into class BaseDocsGenerate

eb17eac

remove drop relation for unique_schema

c5bc8f1

manually define alternate_schema for clean_up as not being seen as pa…

39d2c22

…rt of project_config

McKnight-42 mentioned this pull request Dec 7, 2023

init push to test ci/cd run of test cleanup dbt-labs/dbt-redshift#683

Closed

4 tasks

McKnight-42 marked this pull request as ready for review December 11, 2023 15:51

McKnight-42 requested a review from a team as a code owner December 11, 2023 15:52

update to main

e80fb19

add changelog

8b8cad9

colin-rogers-dbt approved these changes Dec 11, 2023

View reviewed changes

emmyoop requested changes Dec 11, 2023

View reviewed changes

remove unneeded changelog

6cba5ac

McKnight-42 added the Skip Changelog Skips GHA to check for changelog file label Dec 11, 2023

uncomment line that generates new manifest and delete manifest our ch…

c115cea

…anges created

McKnight-42 mentioned this pull request Dec 11, 2023

[CT-3400] Document testing best practices in CONTRIBUTING.md #9111

Open

make sure the manifest test is deleted and readd older version of man…

ecfa829

…ifest.json to appease test

McKnight-42 requested a review from emmyoop December 12, 2023 16:19

McKnight-42 added 2 commits December 12, 2023 11:25

manually revert file to previous commit

a755419

Revert "manually revert file to previous commit"

a540954

This reverts commit a755419.

emmyoop approved these changes Dec 12, 2023

View reviewed changes

McKnight-42 merged commit c2bc2f0 into main Dec 12, 2023
51 checks passed

McKnight-42 deleted the mcknight/test-adding-teardown branch December 12, 2023 19:09

colin-rogers-dbt mentioned this pull request Dec 12, 2023

[CT-3488] [Feature] Generate manifest at build time or in PR #9272

Open

3 tasks

colin-rogers-dbt mentioned this pull request Dec 21, 2023

resolve merge conflict on unparsed.py #9309

Merged

5 tasks

tlento mentioned this pull request Feb 26, 2024

Update dbt-semantic-interfaces dependency to compatible range #9671

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding clean_up methods to basic and unique_id tests #9195

adding clean_up methods to basic and unique_id tests #9195

McKnight-42 commented Dec 1, 2023 •

edited

Loading

github-actions bot commented Dec 1, 2023

codecov bot commented Dec 1, 2023 •

edited

Loading

McKnight-42 commented Dec 4, 2023

colin-rogers-dbt Dec 6, 2023

McKnight-42 Dec 6, 2023 •

edited

Loading

colin-rogers-dbt commented Dec 6, 2023

McKnight-42 commented Dec 6, 2023

emmyoop left a comment

emmyoop Dec 11, 2023

McKnight-42 Dec 11, 2023 •

edited

Loading

emmyoop Dec 11, 2023

emmyoop Dec 11, 2023

McKnight-42 Dec 11, 2023

McKnight-42 Dec 12, 2023

emmyoop Dec 12, 2023 •

edited

Loading

emmyoop Dec 12, 2023

McKnight-42 Dec 12, 2023

emmyoop Dec 11, 2023

emmyoop left a comment •

edited

Loading

adding clean_up methods to basic and unique_id tests #9195

adding clean_up methods to basic and unique_id tests #9195

Conversation

McKnight-42 commented Dec 1, 2023 • edited Loading

Problem

Solution

Testing Process

Checklist

github-actions bot commented Dec 1, 2023

codecov bot commented Dec 1, 2023 • edited Loading

Codecov Report

McKnight-42 commented Dec 4, 2023

Choose a reason for hiding this comment

McKnight-42 Dec 6, 2023 • edited Loading

Choose a reason for hiding this comment

colin-rogers-dbt commented Dec 6, 2023

McKnight-42 commented Dec 6, 2023

emmyoop left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

McKnight-42 Dec 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emmyoop Dec 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emmyoop left a comment • edited Loading

Choose a reason for hiding this comment

McKnight-42 commented Dec 1, 2023 •

edited

Loading

codecov bot commented Dec 1, 2023 •

edited

Loading

McKnight-42 Dec 6, 2023 •

edited

Loading

McKnight-42 Dec 11, 2023 •

edited

Loading

emmyoop Dec 12, 2023 •

edited

Loading

emmyoop left a comment •

edited

Loading