Add fix + test case for #207

dbt-labs · Jul 28, 2021 · 9aacff0 · 9aacff0
1 parent ff34ee1
commit 9aacff0
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,8 @@
-## dbt 0.20.0 (Release TBD)
+## dbt 0.20.1rc1 (Release TBD)
+
+- Fix docs site crash if `relationships` test has one dependency instead of two ([docs#207](https://github.com/dbt-labs/dbt-docs/issues/207), ([docs#208](https://github.com/dbt-labs/dbt-docs/issues/208)))
+
+## dbt 0.20.0 (July 12, 2021
 
 - Update dbt logo and links ([docs#197](https://github.com/fishtown-analytics/dbt-docs/issues/197))
 

diff --git a/ci-project/models/marts/core/schema.yml b/ci-project/models/marts/core/schema.yml
@@ -49,6 +49,11 @@ models:
           - relationships:
               to: ref('dim_customers')
               field: customer_id
+          # intentionally bad: this test will only have one entry in depends_on.nodes.
+          # make sure it doesn't brick the entire dbt-docs site: https://github.com/dbt-labs/dbt-docs/issues/207
+          - relationships:
+              to: "{{ target.schema}}.dim_customers"
+              field: customer_id
 
       - name: order_date
         description: Date (UTC) that the order was placed

diff --git a/ci-project/packages.yml b/ci-project/packages.yml
@@ -1,4 +1,4 @@
 
 packages:
   - package: fishtown-analytics/dbt_utils
-    version: 0.2.5
+    version: 0.7.0
diff --git a/data/catalog.json b/data/catalog.json
diff --git a/data/manifest.json b/data/manifest.json
diff --git a/src/app/services/project_service.js b/src/app/services/project_service.js
@@ -198,7 +198,7 @@ angular
                 var test_column = test.column_name || test.test_metadata.kwargs.column_name || test.test_metadata.kwargs.arg;
                 if (depends_on.length && test_column) {
                     if (test.test_metadata.name == 'relationships') {
-                        var model = depends_on[1];
+                        var model = depends_on[depends_on.length - 1];
                     } else {
                         var model = depends_on[0]
                     }