Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-alphabetical sort of Source Tables in source overview page #218

Merged
merged 3 commits into from
Nov 7, 2021

Conversation

salmonsd
Copy link
Contributor

@salmonsd salmonsd commented Oct 15, 2021

resolves #81

Description

When expanding sources, the source list table that's displayed is unsorted.

Fix:
image

Checklist

  • I have signed the CLA
  • I have generated docs locally, and this change appears to resolve the stated issue
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot
Copy link

cla-bot bot commented Oct 15, 2021

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @salmonsd

@salmonsd salmonsd marked this pull request as ready for review October 15, 2021 17:09
@salmonsd
Copy link
Contributor Author

Hey @drewbanin, CLA has been signed after PR was opened.

@jtcohen6
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Oct 18, 2021
@cla-bot
Copy link

cla-bot bot commented Oct 18, 2021

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @salmonsd, and sorry for the delay in getting back to you! I'm going to merge this for inclusion in dbt Core v1.0.0-rc1, which we're planning to cut this week

@jtcohen6 jtcohen6 merged commit 22ae51d into dbt-labs:master Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-alphabetical sort of Source Tables in source overview page
2 participants