Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with missing exposure details #228

Merged
merged 4 commits into from
Dec 14, 2021
Merged

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Dec 13, 2021

resolves #224

Description

Convert to use 2 separate controllers instead of a shared controller for metrics and exposures with multiple definitions. This allows all fields to show for both kinds of nodes.

Checklist

  • I have signed the CLA
  • I have generated docs locally, and this change appears to resolve the stated issue
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Dec 13, 2021
@emmyoop emmyoop marked this pull request as ready for review December 13, 2021 21:04
@emmyoop emmyoop requested review from iknox-fa and kwigley December 13, 2021 21:16
@emmyoop emmyoop changed the title changes what gets error Fix bug with missing exposure details Dec 13, 2021
@emmyoop emmyoop merged commit 13bc6bd into main Dec 14, 2021
@emmyoop emmyoop deleted the er/exposure-details-missing branch December 14, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exposure pages missing info in v1.0.0
2 participants