Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph list ordering #235

Merged
merged 7 commits into from
Apr 4, 2022
Merged

Graph list ordering #235

merged 7 commits into from
Apr 4, 2022

Conversation

pgoslatara
Copy link
Contributor

@pgoslatara pgoslatara commented Feb 2, 2022

resolves #234

Description

In the drop down lists in the lineage graph, ensure the items are in alphabetical order.

Checklist

  • I have signed the CLA
  • I have generated docs locally, and this change appears to resolve the stated issue
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Feb 2, 2022
@emmyoop emmyoop self-requested a review April 4, 2022 13:46
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pgoslatara thanks so much for putting this together.

Sorry it's taken a bit to get around to reviewing this. I have one small change request and then you'll also need to generate a changelog entry. If you pull in the latest changes to the repo you can just add your changelog under the 1.1.0 heading that exists there.

src/app/services/node_selection_service.js Outdated Show resolved Hide resolved
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks so much for your contribution!

@emmyoop emmyoop merged commit 0ca9c6e into dbt-labs:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lists in lineage graph are not in alphabetical order
2 participants