-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the sample SQL when the source has no database #272
Conversation
Co-authored-by: Stu Kilgore <stuart.kilgore@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I tested locally and it works as expected!
This is going to go in to 1.2.0
. If you pull in recent changes, there's a spot in the CHANGELOG
for that now. Please update your CHANGELOG
entry to be under the accurate release and I'll get this merged in. Also, don't forget to add yourself under Contributors 😃
Thank you so much for the contribution @b-per!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks again!
Sorry, bit late to this, and many thanks to the reviewers, but is it ok that this code will now require model.identifier whereas the old code tried to use model.identifier, model.alias, or model.name? |
I think that it is OK, yes. |
resolves #264
Description
Fix for the issue raised where the sample SQL Code is incorrect when the data source isn't linked to any database (like in databricks).
To test it, I updated the database field in my
manifest.json
, replacing"jaffle_shop"
by""
.Behaviour before the change, when no DB is defined:
Behaviour after the change, when no DB is defined:
Behaviour after the change, when a DB is defined:
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.