run tests in CI #274
Merged
run tests in CI #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahwicz
approved these changes
May 13, 2022
| on: | ||
| pull_request: | ||
| branches: [ main ] | ||
|
|
There was a problem hiding this comment.
Nit: I would scope down the GitHub token to only have limited read permissions
permissions:
contents: read
drewbanin
commented
May 14, 2022
| @@ -442,19 +442,19 @@ test("Test getting nodes by test type", () => { | |||
| expect( | |||
| matchByTestType('data') | |||
| ).toStrictEqual( | |||
| [7] | |||
| [] | |||
There was a problem hiding this comment.
@leahwicz could you (or someone from the Core team) confirm that the changes to these tests are correct? I think that these test were invalid and, if I'm reading this correctly, the node with id=7 is a generic/schema, not a singular/data test.
There was a problem hiding this comment.
@emmyoop could you be a second pair of eyes here please?
There was a problem hiding this comment.
@drewbanin agreed that the test type seems incorrect. Good catch. While in there, you should add a node (id=8) for a singular/data test to test against on lines 445/451 to make the test a bit more complete.
This was referenced May 14, 2022
drewbanin
force-pushed
the
run-tests-in-ci
branch
from
50ba788 to
bb727de
Compare
drewbanin
force-pushed
the
run-tests-in-ci
branch
from
bb727de to
cd18dd1
Compare
emmyoop
approved these changes
May 17, 2022
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR runs automated tests in PRs via a github workflow
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.