-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve metrics docs & DAG viz #285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I confirmed with some testing that it's behaving as expected. However, I'd love to get @stu-k's eyes on this before merging it in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only nitpicky comments about consistency and code style, all of this seems functional as it is now 👍
Co-authored-by: Stu Kilgore <stuart.kilgore@gmail.com>
Co-authored-by: Stu Kilgore <stuart.kilgore@gmail.com>
Co-authored-by: Stu Kilgore <stuart.kilgore@gmail.com>
@stu-k! Thank you so much for this review! I just moved this out of the draft state - lmk if there's anything else I should do before merging! :D |
@drewbanin As long as you tested locally and everything is working as expected, it should be good to go! |
right on - I pulled these new commits down and tested metrics on local. Merging! |
resolves #246
Description
This PR:
Screenshots
Expression metrics render in the DAG view
Render the name, label, and type for each metric
Example metric SQL definition:
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.