Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add contract/constraints #441

Merged
merged 2 commits into from
Aug 7, 2023
Merged

add contract/constraints #441

merged 2 commits into from
Aug 7, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Aug 4, 2023

resolves #433

Description

  • Add details on if there is an enforced contract
    Screenshot 2023-08-03 at 7 20 33 PM
    Screenshot 2023-08-03 at 7 20 55 PM

  • Add details on the column level constraints
    Screenshot 2023-08-03 at 7 21 46 PM

Screenshot 2023-08-03 at 7 21 58 PM

  • Out of scope: Add model level constraints

Checklist

@cla-bot cla-bot bot added the cla:yes label Aug 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop emmyoop marked this pull request as draft August 4, 2023 00:24
@jtcohen6
Copy link
Contributor

jtcohen6 commented Aug 4, 2023

@emmyoop I think you're on the right track!

Add model level constraints somewhere

This does feel trickier, and I'd be okay with kicking it out of scope.

@emmyoop emmyoop marked this pull request as ready for review August 4, 2023 18:21
@emmyoop emmyoop requested a review from QMalcolm August 4, 2023 18:47
Copy link

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My AngularJS knowledge is a little rusty, but this all looks reasonable to me. Lets send it 🚀

@emmyoop emmyoop merged commit 579b24d into main Aug 7, 2023
@emmyoop emmyoop deleted the er/show-contract branch August 7, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2810] [CT-2775] [Feature] Show contracts in project's dbt docs site
3 participants