Official v1 upgrade #119
Merged
Official v1 upgrade #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
force-pushed
the
official-v1-upgrade
branch
from
4e95f8e
to
5e0f22a
Compare
timbrownsf
reviewed
Jan 26, 2022
| {% do dbt_utils.log_info(loop_label ~ ' SKIP') if run_queue == [] %} | ||
| {% set width = 80 %} {# hard code this for now, use PRINTER_WIDTH flag in v1.0+ #} | ||
| {% do log(loop_label ~ ' SKIP', info = true) if run_queue == [] %} | ||
| {% set width = flags.PRINTER_WIDTH %} |
There was a problem hiding this comment.
This is still causing bugs - why did you remove the hardcoding patch from v0.7.3?
There was a problem hiding this comment.
@timbrownsf This version of the package is only for dbt version 1.0 and higher, and the issue was only for versions prior to 1.0 - are you using --no-version-check in your dbt command? you may want to switch back to 0.7.3 instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
dbt_project.ymlto remove deprecation warningsdbt_utilsdependency — this was only being used for logging niceties, which are redundant thanks to new logging in v1Checklist
I have verified that these changes work locallyI have updated the README.md (if applicable)I have added an integration test for my fix/feature (if applicable)