move to GitHub Actions #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataders
force-pushed
the
migrate-to-GHA
branch
from
c95ab0c to
f5dcc03
Compare
dataders
force-pushed
the
migrate-to-GHA
branch
from
f5dcc03 to
276d14d
Compare
dataders
force-pushed
the
migrate-to-GHA
branch
from
8a2cd45 to
766d02e
Compare
dataders
force-pushed
the
migrate-to-GHA
branch
from
bfbb10b to
7cac57f
Compare
jeremyyeo
reviewed
Apr 4, 2024
| max-parallel: 3 | ||
| matrix: | ||
| python-version: [ "3.11"] # "3.10", "3.12"] | ||
| dbt-version: ["1.7.0"] # "1.6.0", , "1.8.0b1"] |
There was a problem hiding this comment.
We used to run ci only on prereleases - might be worth doing:
- Current stable release (
pip install dbt-core dbt-snowflake). - Latest prerelease (
pip install dbt-core dbt-snowflake --pre).
But maybe something to think about for later :)
There was a problem hiding this comment.
100% will have it again eventually. currently blocked on this by #271
replace the var test parallelization add snowflake back retitle add another snowflake env var exclude 3.12 for snowflake K.I.S.S. once more
dataders
commented
Apr 4, 2024
Comment on lines
+43
to
+60
| env: | ||
| REDSHIFT_TEST_HOST: ${{ secrets.REDSHIFT_TEST_HOST }} | ||
| REDSHIFT_TEST_USER: ${{ secrets.REDSHIFT_TEST_USER }} | ||
| REDSHIFT_TEST_PASS: ${{ secrets.REDSHIFT_TEST_PASS }} | ||
| REDSHIFT_TEST_PORT: ${{ secrets.REDSHIFT_TEST_PORT }} | ||
| REDSHIFT_TEST_DBNAME: ${{ secrets.REDSHIFT_TEST_DBNAME }} | ||
| REDSHIFT_SPECTRUM_IAM_ROLE: ${{ secrets.REDSHIFT_SPECTRUM_IAM_ROLE }} | ||
| SNOWFLAKE_TEST_ACCOUNT: ${{ secrets.SNOWFLAKE_TEST_ACCOUNT }} | ||
| SNOWFLAKE_TEST_USER: ${{ secrets.SNOWFLAKE_TEST_USER }} | ||
| SNOWFLAKE_TEST_PASS: ${{ secrets.SNOWFLAKE_TEST_PASS }} | ||
| SNOWFLAKE_TEST_WHNAME: ${{ secrets.SNOWFLAKE_TEST_WHNAME }} | ||
| SNOWFLAKE_TEST_ROLE: ${{ secrets.SNOWFLAKE_TEST_ROLE }} | ||
| SNOWFLAKE_TEST_DBNAME: ${{ secrets.SNOWFLAKE_TEST_DBNAME }} | ||
| BIGQUERY_TEST_PROJECT: ${{ secrets.BIGQUERY_TEST_PROJECT }} | ||
| BIGQUERY_PRIVATE_KEY: ${{ secrets.BIGQUERY_PRIVATE_KEY }} | ||
| BIGQUERY_PRIVATE_KEY_ID: ${{ secrets.BIGQUERY_PRIVATE_KEY_ID }} | ||
| BIGQUERY_CLIENT_EMAIL: ${{ secrets.BIGQUERY_CLIENT_EMAIL }} | ||
| BIGQUERY_CLIENT_ID: ${{ secrets.BIGQUERY_CLIENT_ID }} |
There was a problem hiding this comment.
should these be prefixed by DBT_ENV_SECRET?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
resolves: #262
resolves: #261
resolves: #267