Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update grain of multiple sources joined #64

Merged
merged 6 commits into from
Apr 4, 2022

Conversation

graciegoheen
Copy link
Collaborator

Updated grain of:

  • fct_model_fanout
  • fct_source_fanout
  • fct_multiple_sources_joined

So that one record is equivalent to one error.

Note: Created a listagg macro to (hopefully) ensure cross-database compatibility. @dave-connors-3 or @b-per could you test this out? I'm also wondering if this piece should be added to the dbt-utils package?

@graciegoheen
Copy link
Collaborator Author

Created a PR to add listagg macro to dbt-utils

Copy link
Contributor

@wasilaq wasilaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'm not sure if we want to add the listagg macro to utils. It looks like the implementation of the function in any given individual data warehouse is pretty straightforward

@graciegoheen
Copy link
Collaborator Author

Hmm - @wasilaq I don't think it's about the level of complexity, more so just having the ability to use the function across multiple warehouses (looking @ other cross-database-macros in dbt-utils). For example split_part is pretty easy to implement in different data warehouses, but having the macro available in dbt-utils allows people to use it and ensure cross-data-warehouse compatibility.

@graciegoheen
Copy link
Collaborator Author

PR for adding listagg macro to dbt-utils - we can remove this macro from our package once it's been merged into dbt-utils

@graciegoheen graciegoheen merged commit 1f845ef into main Apr 4, 2022
@graciegoheen graciegoheen deleted the fix/update-grain-of-multiple_sources_joined branch September 21, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants