ADAP-923: Resolve issue where backup parameter was inadvertently considered in configuration change monitoring #657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #621
Problem
The
backup
parameter is considered in configuration change monitoring. However, we're not currently able to query this parameter from Redshift. As a result, settingbackup
equal toFalse
always returns a configuration change since the default value isTrue
. This is a problem whenon_configuration_change='fail'
since the run fails when it should pass.Solution
Add a functional test demonstrating the issue using the reporter's example. Remove
backup
from configuration change monitoring.Checklist