Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.7.latest] Implement relation filtering on get_catalog macro #720

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Feb 26, 2024

Backport b79ced3 from #692.

* changelog
* split out get_catalog by schema and by relation
* fix column references, reverse union order so nulls load second, remove column union and join on multiple columns
* turn on get_catalog by relation capability
* add test cases that demonstrate both catalog methods work
* fix broken import in materialized view tests

(cherry picked from commit b79ced3)
@mikealfare mikealfare self-assigned this Feb 26, 2024
@cla-bot cla-bot bot added the cla:yes label Feb 26, 2024
@mikealfare mikealfare linked an issue Feb 26, 2024 that may be closed by this pull request
3 tasks
@mikealfare mikealfare changed the base branch from main to 1.7.latest February 26, 2024 16:13
@mikealfare mikealfare marked this pull request as draft February 26, 2024 16:22
@mikealfare mikealfare marked this pull request as ready for review February 28, 2024 01:11
@mikealfare mikealfare merged commit 0a2c3f9 into 1.7.latest Feb 28, 2024
26 checks passed
@mikealfare mikealfare deleted the backport/1.7.latest/get-catalog-by-relation branch February 28, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-929] [Feature] Implement relation filtering on get_catalog macro
2 participants