[Bug] Silent SSO token expiration

[mikealfare]

resolves #851

Problem

Expired SSO tokens fail silently.

Solution

Catch the specific exception for an expired SSO token and raise it so the user is aware of why the connection is failing.

Checklist

• I have read the contributing guide and understand what's expected of me
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

[McKnight-42]

looking into the further up swap to a Database Error

looking at open method in connections.py we get to

retryable_exceptions = [
            InternalError,
            InternalServerError,
            ServiceUnavailableError,
            GatewayTimeoutError,
            RequestTimeoutError,
            BadGatewayError,
            OtherHTTPRetryableError,
            BindUploadError,
        ]
        # these two options are for backwards compatibility
        if creds.retry_all:
            retryable_exceptions = [Error]
        elif creds.retry_on_database_errors:
            retryable_exceptions.insert(0, DatabaseError)

        return cls.retry_connection(
            connection,
            connect=connect,
            logger=logger,
            retry_limit=creds.connect_retries,
            retry_timeout=timeout if timeout is not None else exponential_backoff,
            retryable_exceptions=retryable_exceptions,
        )

falling back to dbt-adapters and looking at the method defined there as part of BaseConnectionManager failure seems to happen here

except Exception as e:
            connection.handle = None
            connection.state = ConnectionState.FAIL  # type: ignore
            raise FailedToConnectError(str(e))

applying breakpoint here and checking type and str of e shows:

type(e)
<class 'dbt.adapters.exceptions.connection.FailedToConnectError'>
str: str(e)
'Database Error\n  This error occurs when authentication has expired. Please reauth with your auth provider.'

I'm looking into where the Database Error is getting added on.

the current idea is class DbtDatabaseError which has a MESSAGE = Database Error field and is the direct parent of FailedToConnectError.

[colin-rogers-dbt]

Looking at the test run logs I think the issue here is that as part of test setup we are creating a connection with the database so it's failing in test setup and not in the test_token_expiration method

[McKnight-42]

updated the test, it hits the error then for some reason continues on into a RunTimeError as well