Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAP-788: Unleash the boundsssss #736

Closed
wants to merge 1 commit into from
Closed

Conversation

mikealfare
Copy link
Contributor

Problem

We receive an onslaught of dependabot PRs because we pin our dev requirements to the minor, and sometimes patch. The vast majority pass tests, but require CI to run and someone to go approve them.

Solution

Remove pins on most dev packages, pin problematic packages (black, mypy, tox) to the major.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Aug 10, 2023
@mikealfare mikealfare requested a review from a team as a code owner August 10, 2023 22:56
@mikealfare mikealfare requested a review from Fleid August 10, 2023 22:56
@cla-bot cla-bot bot added the cla:yes label Aug 10, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Aug 10, 2023
@mikealfare mikealfare removed the request for review from Fleid August 11, 2023 02:52
@mikealfare mikealfare changed the title Unleash the boundsssss ADAP-788: Unleash the boundsssss Aug 16, 2023
@mikealfare
Copy link
Contributor Author

This will happen as part of migrating to dbt-adapters

@mikealfare mikealfare closed this Jan 16, 2024
@mikealfare mikealfare deleted the dependencies/dev/unpin branch January 16, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant