Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Migrate to pyproject.toml #737

Closed
wants to merge 10 commits into from
Closed

Conversation

mikealfare
Copy link
Contributor

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

dbt-snowflake currently uses setup.py and a collection of independent configs to build and test. This has been replaced by pyproject.toml as the go-forward config file for python projects. Additionally, there are configs that live in multiple files and differ from each other, leading to inconsistent usage of dev and test tools.

Solution

Config will be migrated as much as possible into pyproject.toml. There are still some projects that haven't migrated to PEP-518, namely pre-commit, flake8, and tox. These will need to live in legacy formats for now. tox and flake8 can only read ini, so they will live in setup.cfg. pre-commit can only read yaml, so it will remain in place, in .pre-commit-config.yaml.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Aug 11, 2023
@cla-bot cla-bot bot added the cla:yes label Aug 11, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@mikealfare
Copy link
Contributor Author

I got too far ahead on this PR. This will be broken down into smaller PRs, such as #835.

@mikealfare mikealfare closed this Nov 19, 2023
@mikealfare mikealfare deleted the feature/pyproject-toml branch January 16, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant