Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAP-348] Incorrect type annotation for data_type_code_to_name #665

Closed
MichelleArk opened this issue Mar 3, 2023 · 0 comments · Fixed by #664
Closed

[ADAP-348] Incorrect type annotation for data_type_code_to_name #665

MichelleArk opened this issue Mar 3, 2023 · 0 comments · Fixed by #664
Assignees
@MichelleArk
Labels
bug Something isn't working

Comments

@MichelleArk
Copy link
Contributor

Example failure: https://github.com/dbt-labs/dbt-spark/actions/runs/4326751516/jobs/7554548565

dbt/adapters/spark/connections.py:496: error: Argument 1 of "data_type_code_to_name" is incompatible with supertype "SQLConnectionManager"; supertype defines the argument type as "Union[int, str]"  [override]
@MichelleArk MichelleArk added the bug Something isn't working label Mar 3, 2023
@MichelleArk MichelleArk self-assigned this Mar 3, 2023
@github-actions github-actions bot changed the title Incorrect type annotation for data_type_code_to_name [ADAP-348] Incorrect type annotation for data_type_code_to_name Mar 3, 2023
@MichelleArk MichelleArk mentioned this issue Mar 3, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichelleArk MichelleArk

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix SparkConnectionManager.data_type_code_to_name for pyodbc dbt-labs/dbt-spark
1 participant
@MichelleArk