Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix SparkConnectionManager.data_type_code_to_name for pyodbc #664

Merged
merged 25 commits into from
Mar 6, 2023
Merged

fix SparkConnectionManager.data_type_code_to_name for pyodbc #664

merged 25 commits into from
Mar 6, 2023

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Mar 3, 2023 •
edited
Loading

resolves #665

Description

Checklist

@cla-bot cla-bot bot added the cla:yes label Mar 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

MichelleArk added 16 commits March 3, 2023 15:33
@MichelleArk MichelleArk force-pushed the get_column_schema_from_query-fix-mypy branch from 44317a1 to c5f7bbb Compare March 4, 2023 00:51
@MichelleArk MichelleArk force-pushed the get_column_schema_from_query-fix-mypy branch from c5f7bbb to 08af8f7 Compare March 4, 2023 00:52
@MichelleArk MichelleArk changed the title fix type annotation on data_type_code_to_name fix SparkConnectionManager.data_type_code_to_name for pyodbc Mar 4, 2023
@MichelleArk MichelleArk force-pushed the get_column_schema_from_query-fix-mypy branch from 3ef5902 to 6cd91b9 Compare March 4, 2023 05:26
@MichelleArk MichelleArk closed this Mar 6, 2023
@MichelleArk MichelleArk reopened this Mar 6, 2023
@MichelleArk MichelleArk force-pushed the get_column_schema_from_query-fix-mypy branch from 6cd91b9 to 980377d Compare March 6, 2023 11:41
@MichelleArk MichelleArk force-pushed the get_column_schema_from_query-fix-mypy branch from 980377d to 5b66236 Compare March 6, 2023 12:20
@MichelleArk MichelleArk marked this pull request as ready for review March 6, 2023 12:43
@MichelleArk MichelleArk requested a review from a team as a code owner March 6, 2023 12:43
@MichelleArk MichelleArk requested a review from VersusFacit March 6, 2023 12:43
@MichelleArk MichelleArk merged commit 0cb64bc into main Mar 6, 2023
@MichelleArk MichelleArk deleted the get_column_schema_from_query-fix-mypy branch March 6, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare left review comments

@nssalian nssalian nssalian approved these changes

@VersusFacit VersusFacit Awaiting requested review from VersusFacit VersusFacit is a code owner automatically assigned from dbt-labs/adapters

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADAP-348] Incorrect type annotation for data_type_code_to_name
3 participants
@MichelleArk @nssalian @mikealfare