Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more detailed feedback when pyodbc import fails #192

Merged
merged 7 commits into from
Aug 10, 2021
Merged

Show more detailed feedback when pyodbc import fails #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8ab0e14
Use exception chaining to get more detailed feedback when pyodbc is n…
JCZuurmond Jul 14, 2021
7837c28
Remove pyodbc referenced before assignment
JCZuurmond Jul 14, 2021
b98bc8b
Set back try except
JCZuurmond Jul 14, 2021
d136c52
Add flake ignore
JCZuurmond Jul 14, 2021
fd0bab5
Add error message to RunTimeException
JCZuurmond Jul 14, 2021
fd400ac
Update change log
JCZuurmond Jul 14, 2021
f4b74e3
Fix parenthesis in change log
JCZuurmond Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

### Features

- Add support for `merge_update_columns` config in `merge`-strategy incremental models ([#183](https://github.com/fishtown-analytics/dbt-spark/pull/183), ([#184](https://github.com/fishtown-analytics/dbt-spark/pull/184))
- Add support for `merge_update_columns` config in `merge`-strategy incremental models ([#183](https://github.com/fishtown-analytics/dbt-spark/pull/183), [#184](https://github.com/fishtown-analytics/dbt-spark/pull/184))
- Add pyodbc import error message to dbt.exceptions.RuntimeException to get more detailed information when running `dbt debug` ([#192](https://github.com/dbt-labs/dbt-spark/pull/192))

### Fixes

Expand Down
18 changes: 11 additions & 7 deletions dbt/adapters/spark/connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,17 @@ def __post_init__(self):
)
self.database = None

if self.method == SparkConnectionMethod.ODBC and pyodbc is None:
raise dbt.exceptions.RuntimeException(
f"{self.method} connection method requires "
"additional dependencies. \n"
"Install the additional required dependencies with "
"`pip install dbt-spark[ODBC]`"
)
if self.method == SparkConnectionMethod.ODBC:
try:
import pyodbc # noqa: F401
except ImportError as e:
raise dbt.exceptions.RuntimeException(
f"{self.method} connection method requires "
"additional dependencies. \n"
"Install the additional required dependencies with "
"`pip install dbt-spark[ODBC]`\n\n"
f"ImportError({e.msg})"
) from e

if (
self.method == SparkConnectionMethod.ODBC and
Expand Down